benchmark: refactor benchmark/common.js#25805
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Refactor benchmark/common.js to consistently use arrow functions for anonymous callbacks and trailing commas.
nodejs-github-bot
added
the
benchmark
jasnell
approved these changes
Jan 29, 2019
BethGriggs
approved these changes
Jan 30, 2019
Trott
added
the
author ready
Member
Author
Member
Author
|
Whoops, that was a benchmark CI against master. Here's one against this PR: https://ci.nodejs.org/job/node-test-commit-custom-suites/851/ |
lpinca
approved these changes
Jan 30, 2019
Member
lpinca
left a comment
lpinca
left a comment
There was a problem hiding this comment.
I think this kind of changes could be done with tools like eslint.
Member
Author
|
Landed in 7c9fba3 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 1, 2019
Refactor benchmark/common.js to consistently use arrow functions for anonymous callbacks and trailing commas. PR-URL: nodejs#25805 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 1, 2019
Refactor benchmark/common.js to consistently use arrow functions for anonymous callbacks and trailing commas. PR-URL: #25805 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor benchmark/common.js to consistently use arrow functions for
anonymous callbacks and trailing commas.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes