worker: export workerData to ESM workers#25768
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
worker: export workerData to ESM workers#25768addaleax wants to merge 2 commits intonodejs:masterfrom
addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
addaleax
added
esm
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/20374/ (:heavy_check_mark:) |
devsnek
approved these changes
Jan 28, 2019
devsnek
reviewed
Jan 28, 2019
cjihrig
approved these changes
Jan 28, 2019
|
Impressive how quickly this was addressed. Thanks @addaleax! |
TimothyGu
approved these changes
Jan 28, 2019
addaleax
added
the
author ready
Fishrock123
approved these changes
Jan 29, 2019
lpinca
approved these changes
Jan 29, 2019
jasnell
approved these changes
Jan 29, 2019
Member
Author
|
Landed in 8919169 |
addaleax
added a commit
that referenced
this pull request
Jan 30, 2019
Fixes: #25765 PR-URL: #25768 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 30, 2019
Fixes: #25765 PR-URL: #25768 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #25765
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes