report: use consistent format for dumpEventTime#25751
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
report: use consistent format for dumpEventTime#25751addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Use the same JS-compatible format on both POSIX and Windows.
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Jan 28, 2019
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. Any idea why it was done like this originally?
Member
No idea. The equivalent code in the standalone module is consistent (both Windows and non-Windows use |
richardlau
approved these changes
Jan 28, 2019
jasnell
approved these changes
Jan 28, 2019
gireeshpunathil
approved these changes
Jan 28, 2019
Member
@cjihrig - no specific reason I can recollect; so may be a slip when I changed many things in succession. |
Member
Author
addaleax
added
the
author ready
Member
Author
Member
Author
|
Landed in 23d51a1 |
addaleax
added a commit
that referenced
this pull request
Jan 30, 2019
Use the same JS-compatible format on both POSIX and Windows. PR-URL: #25751 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax
added a commit
that referenced
this pull request
Jan 30, 2019
Use the same JS-compatible format on both POSIX and Windows. PR-URL: #25751 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the same JS-compatible format on both POSIX and Windows.
Side note: It might be nice to wrap up all the different date-handling pieces of code in a single place, with a single mechanism and using some standardized format(s).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes