src: pass along errors from object instantiations#25734
Closed
addaleax wants to merge 7 commits intonodejs:masterfrom
Closed
src: pass along errors from object instantiations#25734addaleax wants to merge 7 commits intonodejs:masterfrom
addaleax wants to merge 7 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
jasnell
approved these changes
Jan 28, 2019
Member
Author
Member
Author
devsnek
approved these changes
Jan 29, 2019
addaleax
added
the
author ready
Member
Author
|
Landed in 1a37fd6...8e6667f |
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
joyeecheung
reviewed
Jan 29, 2019
| MaybeLocal<Object> Environment::CreateProcessObject( | ||
| const std::vector<std::string>& args, | ||
| const std::vector<std::string>& exec_args) { | ||
| if (*TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED( |
Member
There was a problem hiding this comment.
Why is this part inside CreateProcessObject? (Or rather why is this method named CreateProcessObject?)
Member
Author
There was a problem hiding this comment.
@joyeecheung Because it’s the part that handles args and exec_args, that’s pretty much all the reason … also, I called it that because that’s what it mainly does, create + set up the process object?
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jan 30, 2019
PR-URL: nodejs#25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
2 tasks
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Function::NewInstance()can always fail in the presence of termination exceptions, so we need to check for error conditions when calling it.This PR does not address all of those cases, but at least some of them.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes