doc: Fix issue with worker_threads docs#25712
Closed
leebyron wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
this example function returns a promise directly rather than implicitly via async/await
leebyron
changed the title
lpinca
approved these changes
Jan 25, 2019
cjihrig
approved these changes
Jan 25, 2019
vsemozhetbyt
added
the
author ready
Contributor
vsemozhetbyt
pushed a commit
that referenced
this pull request
Jan 29, 2019
This example function returns a promise directly rather than implicitly via async/await. PR-URL: #25712 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
|
Landed in a0419dd |
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
This example function returns a promise directly rather than implicitly via async/await. PR-URL: #25712 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this example function returns a promise directly rather than implicitly via async/await
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes