test: fix sequential/test-performance delay#25695
Closed
apapirovski wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix sequential/test-performance delay#25695apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
TimothyGu
approved these changes
Jan 25, 2019
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
These are some… quite slow machines. But LGTM, if they are confirmed to fix the flakiness to a satisfactory level.
Member
Indeed a Raspberry Pi can have as little as 256 Mb of RAM and a 700 MHz processor. Not sure if that's the spec for these machines, but it certainly gives you the idea. |
Trott
added
the
author ready
Trott
approved these changes
Jan 25, 2019
Member
|
Please 👍 here to approve fast-tracking to unbreak CI. |
cjihrig
approved these changes
Jan 25, 2019
Fishrock123
approved these changes
Jan 25, 2019
Member
|
Landed in d1d357d |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 26, 2019
PR-URL: nodejs#25695 Fixes: nodejs#23291 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
PR-URL: #25695 Fixes: #23291 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #25695 Fixes: #23291 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #25695 Fixes: #23291 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
PR-URL: #25695 Fixes: #23291 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve the flakiness on this test on slower systems where the inited time we store in JS can be much later than the nodeTiming one.
Fixes: #23291
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes