Closed
Conversation
Fix test/pummel/test-exec.js which broke as a result of e47f972 (nodejs#24951). (Until very recently, pummel tests were not run at all in CI and currently only run nightly on master.)
Fishrock123
approved these changes
Jan 24, 2019
Contributor
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
seems about right to me, didn't think to check these..
Trott
added
the
author ready
Member
Author
|
(Pummel tests aren't run in CI, so lite CI should be sufficient. Might run a pummel-specific CI once another PR fixing two other pummel tests lands.) |
danbev
approved these changes
Jan 24, 2019
antsmartian
approved these changes
Jan 24, 2019
cjihrig
approved these changes
Jan 24, 2019
Member
Author
|
nightly-master pummel test job is broken until this lands. Please 👍 here to fast-track. |
gireeshpunathil
approved these changes
Jan 24, 2019
Member
Author
|
Landed in 0c6b5ce |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 24, 2019
Fix test/pummel/test-exec.js which broke as a result of e47f972 (nodejs#24951). (Until very recently, pummel tests were not run at all in CI and currently only run nightly on master.) PR-URL: nodejs#25677 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2019
Fix test/pummel/test-exec.js which broke as a result of e47f972 (#24951). (Until very recently, pummel tests were not run at all in CI and currently only run nightly on master.) PR-URL: #25677 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
Fix test/pummel/test-exec.js which broke as a result of e47f972 (#24951). (Until very recently, pummel tests were not run at all in CI and currently only run nightly on master.) PR-URL: #25677 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Fix test/pummel/test-exec.js which broke as a result of e47f972 (#24951). (Until very recently, pummel tests were not run at all in CI and currently only run nightly on master.) PR-URL: #25677 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Fix test/pummel/test-exec.js which broke as a result of e47f972 (#24951). (Until very recently, pummel tests were not run at all in CI and currently only run nightly on master.) PR-URL: #25677 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test/pummel/test-exec.js which broke as a result of
e47f972
(#24951).
(Until very recently, pummel tests were not run at all in CI and
currently only run nightly on master.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes