test, tools: suppress addon function cast warnings

[danbev]

Currently, there are a number of compiler warnings generated when
building the addons on Linux, for example:

make[1]: Entering directory '/node/test/addons/zlib-binding/build'
  CXX(target) Release/obj.target/binding/binding.o
  SOLINK_MODULE(target) Release/obj.target/binding.node
  COPY Release/binding.node
make[1]: Leaving directory '/node/test/addons/zlib-binding/build'
In file included from ../binding.cc:1:
/node/src/node.h:515:51: warning:
cast between incompatible function types from
'void (*)(v8::Local<v8::Object>,
          v8::Local<v8::Value>,
          v8::Local<v8::Context>)' to
'node::addon_context_register_func' {aka
'void (*)(v8::Local<v8::Object>,
          v8::Local<v8::Value>,
          v8::Local<v8::Context>,
          void*)'} [-Wcast-function-type]
(node::addon_context_register_func) (regfunc), \
					   ^
/node/src/node.h:533:3:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X'
   NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../binding.cc:58:1:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE'
 NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
 ^~~~~~~~~~~~~~~~~~~~~~~~~

This commit adds the flag -Wno-cast-function-type to suppress these
warnings. With this change the warnings are not displayed anymore and
the output matches that of osx when running
make -j8 test/addons/.buildstamp

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2356/pipeline

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/20283/

[danbev]

Re-run of failing node-test-commit-freebsd (✔️)

[bnoordhuis]

I'm curious, does this actually work with clang? Older gcc versions silently accept unknown -Wno-whatever flags so no problem there but I would expect clang to complain.

[danbev]

I'm curious, does this actually work with clang?

I don't like writing this but, it works for me.

I'm using the following clang version:

$ clang --version
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I can run the following commands successfully and without any warnings

$ make test-addons-clean
$ make -j8 test-addons
...
[00:26|% 100|+  53|-   0]: Done

Should the added flag perhaps be conditionally only for linux OS to be on the safe side?

[danbev]

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/20369/

[bnoordhuis]

LGTM but it might be nicer to DRY it out and move it into a to-be-created test/addons/common.gypi that you include with 'includes': ['../common.gypi'].

(Could also be done for 'defines' since it always the same.)

[danbev]

LGTM but it might be nicer to DRY it out and move it into a to-be-created test/addons/common.gypi that you include with 'includes': ['../common.gypi'].

Yeah, that sounds much better, I'll update later today. Thanks!

[danbev]

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/20502/

[danbev]

Landed in f4510c4.