lib: refactor policy code for readability#25629
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
lib: refactor policy code for readability#25629addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Simplify a few particularly quirky bits of code, and add whitespace for readability.
nodejs-github-bot
added
the
process
lundibundi
approved these changes
Jan 21, 2019
| } | ||
| } = require('buffer'); | ||
|
|
||
| const BufferFrom = require('buffer').Buffer.from; |
cjihrig
approved these changes
Jan 21, 2019
devsnek
approved these changes
Jan 21, 2019
antsmartian
approved these changes
Jan 22, 2019
Contributor
thefourtheye
approved these changes
Jan 22, 2019
addaleax
added
the
author ready
Member
Author
Contributor
|
Landed in 0f5c14c. |
addaleax
added a commit
that referenced
this pull request
Jan 28, 2019
Simplify a few particularly quirky bits of code, and add whitespace for readability. PR-URL: #25629 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify a few particularly quirky bits of code, and add
whitespace for readability.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes