src: invoke per-isolate setters earlier by joyeecheung · Pull Request #25608 · nodejs/node

joyeecheung · 2019-01-21T12:36:54Z

This patch moves the invocation of:

SetHostInitializeImportMetaObjectCallback
SetHostImportModuleDynamicallyCallback
SetPromiseRejectCallback

and the DTrace-related:

AddGCPrologueCallback(DTraceGCStartCallback)
AddGCEpilogueCallback(DTraceGCEndCallback).

into node::NewIsolate(), and moves the performance-timeline-related:

AddGCPrologueCallback(performance::MarkGarbageCollectionStart)
AddGCEpilogueCallback(performance::MarkGarbageCollectionEnd)

that needs per-Environment data into the Environment constructor,
instead of scattering the initialization code around in bindings.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This patch moves the invocation of: - `SetHostInitializeImportMetaObjectCallback` - `SetHostImportModuleDynamicallyCallback` - `SetPromiseRejectCallback` and the DTrace-related: - `AddGCPrologueCallback(DTraceGCStartCallback)` - `AddGCEpilogueCallback(DTraceGCEndCallback)`. into `node::NewIsolate()`, and moves the performance-timeline-related: - `AddGCPrologueCallback(performance::MarkGarbageCollectionStart)` - `AddGCEpilogueCallback(performance::MarkGarbageCollectionEnd)` that needs per-Environment data into the `Environment` constructor, instead of scattering the initialization code around in bindings.

nodejs-github-bot · 2019-01-21T12:36:56Z

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2315/pipeline

joyeecheung · 2019-01-21T12:41:57Z

src/node.cc


+  // NOTE: the following two callbacks currently CHECKs that the isolates
+  // have associated environments.
+  isolate->SetHostInitializeImportMetaObjectCallback(


I am not entirely sure if we should do this here, or in Environment constructor, since these two callbacks do not handle the cases when the isolates' current context does not have Environments associated. Does it make sense to simply crash if the user tries to access import() or import.meta from a context without an associated environment? Or should we return an empty Maybe/do nothing in the callbacks instead? Or should we postpone this to the Environment initialization? (But then the Environments would control per-isolate states)

It’s tricky… I think for now crashing is okay (and the best we can do), and anything more would require interaction with embedders (which would be the main source for this not working).

i don't think these esm ones should have been moved. they are set in response to core opting into handling them. if the handlers don't get attached, we shouldn't have these handlers enabled.

I think I agree with @devsnek. Embedders can install their own after the call to NewIsolate().

joyeecheung · 2019-01-21T12:46:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/20225/

addaleax · 2019-01-21T14:44:36Z

src/node.cc


+  // NOTE: the following two callbacks currently CHECKs that the isolates
+  // have associated environments.
+  isolate->SetHostInitializeImportMetaObjectCallback(


It’s tricky… I think for now crashing is okay (and the best we can do), and anything more would require interaction with embedders (which would be the main source for this not working).

addaleax · 2019-01-21T14:45:01Z

src/node_perf.cc

                            constants,
                            attr).ToChecked();
-
-  SetupGarbageCollectionTracking(env);


I would actually prefer for this to stay here. It makes the code more local and more obvious to me, and only adds the callbacks when they are actually used.

@addaleax this is currently unconditionally called when the isolate goes through bootstrapping - maybe this should be delayed until the first time the user adds an gc performance observer..

@joyeecheung If that’s feasible, it sounds good to me, but I’m more worried about code organization than performance.

Also, I’m just noticing that we never remove these listeners … that’s a bug that we should fix if we can?

See #25647 – I’m happy to close it if you want to do sth in this PR :)

@addaleax Thanks, I think I'd prefer wrapping SetupGarbageCollectionTracking into a binding method and call it from JS when it's actually needed - that's probably orthorgnal to #25647

bnoordhuis · 2019-01-21T18:53:21Z

src/node.cc


+  // NOTE: the following two callbacks currently CHECKs that the isolates
+  // have associated environments.
+  isolate->SetHostInitializeImportMetaObjectCallback(


I think I agree with @devsnek. Embedders can install their own after the call to NewIsolate().

bnoordhuis · 2019-01-21T18:54:35Z

src/node.cc

+  isolate->SetHostImportModuleDynamicallyCallback(
+      loader::ModuleWrap::ImportModuleDynamically);
+
+#if defined HAVE_DTRACE || defined HAVE_ETW


Since you're here: #if defined(HAVE_DTRACE) || defined(HAVE_ETW) - the paren-less style is unidiomatic.

joyeecheung · 2019-01-31T23:37:34Z

Blocked by #25853

joyeecheung · 2019-02-07T18:53:16Z

On a second thought, I think the current invocation order looks more reasonable, so I am closing this PR.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 21, 2019

joyeecheung commented Jan 21, 2019

View reviewed changes

joyeecheung requested review from addaleax and bnoordhuis and removed request for addaleax January 21, 2019 12:46

addaleax reviewed Jan 21, 2019

View reviewed changes

bnoordhuis reviewed Jan 21, 2019

View reviewed changes

joyeecheung added the blocked PRs that are blocked by other issues or PRs. label Jan 31, 2019

joyeecheung removed the blocked PRs that are blocked by other issues or PRs. label Feb 7, 2019

joyeecheung closed this Feb 7, 2019

Uh oh!

Conversation

joyeecheung commented Jan 21, 2019

Checklist

Uh oh!

nodejs-github-bot commented Jan 21, 2019

Uh oh!

joyeecheung Jan 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devsnek Jan 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jan 21, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joyeecheung Jan 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jan 31, 2019

Uh oh!

joyeecheung commented Feb 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joyeecheung Jan 21, 2019 •

edited

Loading

devsnek Jan 21, 2019 •

edited

Loading

joyeecheung Jan 23, 2019 •

edited

Loading