test: remove potential race condition in https renegotiation test#25601
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove potential race condition in https renegotiation test#25601Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is set by the server and checked by the client, which is a separate process launched with child_process.spawn(). The boolean is not actually required by the client and might even be causing a race condition on some operating systems. Remove it.
Member
Author
addaleax
approved these changes
Jan 21, 2019
| @@ -77,7 +74,6 @@ function test(next) { | |||
| let renegs = 0; | |||
|
|
|||
| child.stderr.on('data', function(data) { | |||
Member
There was a problem hiding this comment.
Using .on('data') without any sort of buffering might also be very brittle and something that we should fix…?
Member
Author
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20275/ Will have to update the commit message because it's a bit wonky/wrong, but I'm looking forward to landing this one because stress tests show that it fixes the flaky pummel test! 🎉 Once it lands, we'll have to do the same for test-tls-ci-reneg-attack.js. Will open a PR for that now-ish.... |
Member
Author
|
Landed in c9208f7 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 23, 2019
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is causing a race condition on some operating systems. It is unnecessary. Remove it. PR-URL: nodejs#25601 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is causing a race condition on some operating systems. It is unnecessary. Remove it. PR-URL: #25601 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is causing a race condition on some operating systems. It is unnecessary. Remove it. PR-URL: #25601 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is causing a race condition on some operating systems. It is unnecessary. Remove it. PR-URL: #25601 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is causing a race condition on some operating systems. It is unnecessary. Remove it. PR-URL: #25601 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is
set by the server and checked by the client, which is a separate process
launched with child_process.spawn(). The boolean is not actually
required by the client and might even be causing a race condition on
some operating systems. Remove it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes