lib: remove dollar symbol for private function '$getMaxListeners'

[ghost]

Just remove '$' because this isn't a programming language like Python.

---

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[devsnek]

this doesn't really need an underscore either

[addaleax]

@Maledong I think that’s because of the second getMaxListeners in EventEmitter.prototype.getMaxListeners = function getMaxListeners() { .... I think we can just remove that too.

[devsnek]

@addaleax iirc the name was added as part of a code+learn to help debugging through core, might be good to keep it.

[addaleax]

CI: https://ci.nodejs.org/job/node-test-pull-request/20387/

[danbev]

Re-run of failing node-test-commit-arm-fanned

[joyeecheung]

iirc the name was added as part of a code+learn to help debugging through core, might be good to keep it.

I believe v8 is already capable of inferring function names like this (assigned through a = so it's pretty trivial for the stack-based inferrer)? (And with even more additional context when collecting error stack traces, e.g. the original name and the new name if they are different)

[addaleax]

Landed in 3a4521a

[ghost]

Thanks!