test: improve known_issues/test-vm-timeout-escape-queuemicrotask#25503
test: improve known_issues/test-vm-timeout-escape-queuemicrotask#25503Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message.
|
@Trott sadly an error occured when I tried to trigger a build :( |
|
CI against master hopefully showing this flaky on ubuntu1604-arm64: https://ci.nodejs.org/job/node-stress-single-test/2132/ - (0/1000 OK) CI against this PR hopefully showing it reliable on ubuntu1604-arm64: https://ci.nodejs.org/job/node-stress-single-test/2133/ CI (scheduled): https://ci.nodejs.org/job/node-test-pull-request/20126/ |
|
Seems to be overwhelmingly better. As in pre-PR 0/1000 iterations passed, and post-PR ATM all iterations pass (151/151). Just to make sure, both tests run on |
refack
added
known limitation
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
🎉 thanks, have been wrestling with this trying to get a few branches to pass.
|
Unrelated failure in another test on Windows. Re-running just Windows (because still waiting for AIX which hasn't even started yet): https://ci.nodejs.org/job/node-test-commit-windows-fanned/23965/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20132/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20133/ Three failures in a row on Windows for parallel/test-trace-events-fs-sync. Starting to worry about that one.... |
|
Did a full CI re-run and this time Windows passed: https://ci.nodejs.org/job/node-test-commit/25058/ Re-running FreeBSD (only failure, unrelated): https://ci.nodejs.org/job/node-test-commit-freebsd/23400/ |
|
FreeBSD re-run was green. Landing... Landed in 27f6d04 |
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message. PR-URL: nodejs#25503 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message. PR-URL: #25503 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message. PR-URL: nodejs#25503 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message. PR-URL: nodejs#25503 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
5 participants
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use
common.platformTimeout()to help, adjust timeout to make surequeueMicrotasks()has a chance to run, and improve error message.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes