process: move worker execution to executeUserCode()#25471
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
process: move worker execution to executeUserCode()#25471joyeecheung wants to merge 1 commit intonodejs:masterfrom
executeUserCode()#25471joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
As this part is executing a "main" script provided by users - the difference is that the content is specified through a port instead of through the CLI.
Collaborator
|
@joyeecheung sadly an error occured when I tried to trigger a build :( |
addaleax
approved these changes
Jan 13, 2019
Member
Author
|
On a second thought, this may not be the best way to refactor this bit...I opened #25474 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this part is executing a "main" script provided by users - the
difference is that the content is specified through a port instead
of through the CLI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes