Closed
Conversation
nodejs-github-bot
added
doc
- parameter `resource_object` is mandatory
DaAitch
force-pushed
the
fix/doc_napi_open_callback_scope
branch
from
b83d610 to
94a5373
Compare
mhdawson
approved these changes
Jan 7, 2019
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM since it documents current behavior.
Contributor
Contributor
|
Landed in 9e7d4ca |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Jan 13, 2019
- parameter `resource_object` is mandatory PR-URL: #25366 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
- parameter `resource_object` is mandatory PR-URL: #25366 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
- parameter `resource_object` is mandatory PR-URL: nodejs#25366 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
- parameter `resource_object` is mandatory PR-URL: #25366 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
- parameter `resource_object` is mandatory PR-URL: #25366 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
- parameter `resource_object` is mandatory PR-URL: #25366 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resource_objectis mandatoryChecklist
Description
According to documention
napi_open_callback_scope's parameterresource_objectis optional., but when I do this:
status = napi_open_callback_scope(env, nullptr, async_context, &scope);I get
napi_invalid_argand when I do this:it's
napi_ok, so I checked impl and found this in node_api.cc:which makes me think that documentation is wrong, so here the PR for documentation.