buffer: make Buffer binding and prototype setup more straight-forward by joyeecheung · Pull Request #25292 · nodejs/node

joyeecheung · 2018-12-31T08:52:12Z

buffer: move initialization of buffer prototype into node.js

Instead of exposing setBufferJS in lib/internal/buffer.js after deleting
it from the binding and then do the initialization in
lib/buffer.js, which results in an implicit dependency on
the order in which these modules are loaded.

buffer: move Buffer prototype wiring into internal/buffer.js

Instead of exposing the Buffer prototype methods through an
object in internal/buffer.js and then iterating over it
to put the methods on the prototype, create a function
in internal/buffer.js to do this.

Also moves the creation of the FastBuffer class into
internal/buffer.js and expose it directly instead of
writing it onto that module later.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Instead of exposing it in `lib/internal/buffer.js` after deleting it from the binding and then do the initialization in `lib/buffer.js`, which results in an implicit dependency on the order in which these modules are loaded.

Instead of exposing the Buffer prototype methods through an object in `internal/buffer.js` and then iterating over it to put the methods on the prototype, create a function in `internal/buffer.js` to do this. Also moves the creaton of the `FastBuffer` class into `internal/buffer.js` and expose it directly instead of writing it onto that module later.

nodejs-github-bot · 2018-12-31T08:52:14Z

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2116/pipeline

joyeecheung · 2018-12-31T09:00:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19894/

joyeecheung · 2019-01-02T12:50:33Z

Ping @nodejs/process @nodejs/buffer can I have some review please?

joyeecheung · 2019-01-02T12:53:35Z

lib/internal/buffer.js

+class FastBuffer extends Uint8Array {}
+
+function addBufferPrototypeMethods(proto) {
+  proto.readUIntLE = readUIntLE;


Another way to do this is to put all these to the prototype of FastBuffer, I am not sure if there are any concerns about edge cases though

I am fine either way.

joyeecheung · 2019-01-04T17:21:10Z

Ping again..according to the GitHub reviewer recommendations: @BridgeAR @TimothyGu @addaleax

addaleax

Code LGTM

joyeecheung · 2019-01-09T15:08:07Z

Fresh CI: https://ci.nodejs.org/job/node-test-pull-request/20023/

Instead of exposing it in `lib/internal/buffer.js` after deleting it from the binding and then do the initialization in `lib/buffer.js`, which results in an implicit dependency on the order in which these modules are loaded. PR-URL: #25292 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Instead of exposing the Buffer prototype methods through an object in `internal/buffer.js` and then iterating over it to put the methods on the prototype, create a function in `internal/buffer.js` to do this. Also moves the creaton of the `FastBuffer` class into `internal/buffer.js` and expose it directly instead of writing it onto that module later. PR-URL: #25292 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

joyeecheung · 2019-01-10T09:27:16Z

Landed in fa5af0d...842a35f

addaleax · 2019-01-15T23:10:55Z

@joyeecheung Can you look into backporting this to v11.x-staging?

BridgeAR · 2019-01-16T14:24:26Z

I pushed a backport directly onto v11.x-staging. There was just a minor conflict in lib/internal/bootstrap/node.js.

Instead of exposing it in `lib/internal/buffer.js` after deleting it from the binding and then do the initialization in `lib/buffer.js`, which results in an implicit dependency on the order in which these modules are loaded. PR-URL: #25292 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Instead of exposing the Buffer prototype methods through an object in `internal/buffer.js` and then iterating over it to put the methods on the prototype, create a function in `internal/buffer.js` to do this. Also moves the creaton of the `FastBuffer` class into `internal/buffer.js` and expose it directly instead of writing it onto that module later. PR-URL: #25292 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Instead of exposing it in `lib/internal/buffer.js` after deleting it from the binding and then do the initialization in `lib/buffer.js`, which results in an implicit dependency on the order in which these modules are loaded. PR-URL: nodejs#25292 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Instead of exposing the Buffer prototype methods through an object in `internal/buffer.js` and then iterating over it to put the methods on the prototype, create a function in `internal/buffer.js` to do this. Also moves the creaton of the `FastBuffer` class into `internal/buffer.js` and expose it directly instead of writing it onto that module later. PR-URL: nodejs#25292 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Instead of exposing it in `lib/internal/buffer.js` after deleting it from the binding and then do the initialization in `lib/buffer.js`, which results in an implicit dependency on the order in which these modules are loaded. PR-URL: nodejs#25292 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Instead of exposing the Buffer prototype methods through an object in `internal/buffer.js` and then iterating over it to put the methods on the prototype, create a function in `internal/buffer.js` to do this. Also moves the creaton of the `FastBuffer` class into `internal/buffer.js` and expose it directly instead of writing it onto that module later. PR-URL: nodejs#25292 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

joyeecheung added 2 commits December 31, 2018 16:43

buffer: move initialization of buffer prototype into node.js

fa6b492

Instead of exposing it in `lib/internal/buffer.js` after deleting it from the binding and then do the initialization in `lib/buffer.js`, which results in an implicit dependency on the order in which these modules are loaded.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 31, 2018

joyeecheung commented Jan 2, 2019

View reviewed changes

addaleax approved these changes Jan 4, 2019

View reviewed changes

joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2019

jasnell approved these changes Jan 9, 2019

View reviewed changes

BridgeAR approved these changes Jan 10, 2019

View reviewed changes

joyeecheung closed this Jan 10, 2019

addaleax added the backport-requested-v11.x label Jan 15, 2019

BridgeAR added backported-to-v11.x and removed backport-requested-v11.x labels Jan 16, 2019

BridgeAR mentioned this pull request Jan 16, 2019

v11.7.0 proposal #25537

Merged

MylesBorins mentioned this pull request Jan 24, 2019

v11.8.0 proposal #25687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

buffer: make Buffer binding and prototype setup more straight-forward#25292

buffer: make Buffer binding and prototype setup more straight-forward#25292
joyeecheung wants to merge 2 commits intonodejs:masterfrom
joyeecheung:clean-buffer

joyeecheung commented Dec 31, 2018

Uh oh!

nodejs-github-bot commented Dec 31, 2018

Uh oh!

joyeecheung commented Dec 31, 2018

Uh oh!

joyeecheung commented Jan 2, 2019

Uh oh!

joyeecheung Jan 2, 2019

Uh oh!

BridgeAR Jan 10, 2019

Uh oh!

joyeecheung commented Jan 4, 2019

Uh oh!

addaleax left a comment

Uh oh!

joyeecheung commented Jan 9, 2019

Uh oh!

joyeecheung commented Jan 10, 2019

Uh oh!

addaleax commented Jan 15, 2019

Uh oh!

BridgeAR commented Jan 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

joyeecheung commented Dec 31, 2018

buffer: move initialization of buffer prototype into node.js

buffer: move Buffer prototype wiring into internal/buffer.js

Checklist

Uh oh!

nodejs-github-bot commented Dec 31, 2018

Uh oh!

joyeecheung commented Dec 31, 2018

Uh oh!

joyeecheung commented Jan 2, 2019

Uh oh!

joyeecheung Jan 2, 2019

Choose a reason for hiding this comment

Uh oh!

BridgeAR Jan 10, 2019

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jan 4, 2019

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jan 9, 2019

Uh oh!

joyeecheung commented Jan 10, 2019

Uh oh!

addaleax commented Jan 15, 2019

Uh oh!

BridgeAR commented Jan 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants