Skip to content

deps: V8: cherry-pick 56f6a76#25269

Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:fix-weird-numbers-master
Closed

deps: V8: cherry-pick 56f6a76#25269
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:fix-weird-numbers-master

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Dec 29, 2018 •
edited
Loading

Original commit message:

[turbofan] Fix -0 check for subnormals.

Previously we'd check `x` for -0 by testing `(1.0 / x) == -Infinity`,
but this will yield the wrong results when `x` is a subnormal, i.e.
really close to 0.

In CSA we already perform bit checks to test for -0, so teach TurboFan
to do the same for comparisons to -0 (via `Object.is`). We introduce a
new NumberIsMinusZero simplified operator to handle the case where
SimplifiedLowering already knows that the input is a number.

Bug: chromium:903043, v8:6882
Change-Id: I0cb7c568029b461a92fc183104d5f359b4bfe7f4
Reviewed-on: https://chromium-review.googlesource.com/c/1328802
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57382}

Refs: v8/v8@56f6a76

Fixes: #25268

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
deps: V8: cherry-pick 56f6a76
968a707 
Original commit message:

    [turbofan] Fix -0 check for subnormals.

    Previously we'd check `x` for -0 by testing `(1.0 / x) == -Infinity`,
    but this will yield the wrong results when `x` is a subnormal, i.e.
    really close to 0.

    In CSA we already perform bit checks to test for -0, so teach TurboFan
    to do the same for comparisons to -0 (via `Object.is`). We introduce a
    new NumberIsMinusZero simplified operator to handle the case where
    SimplifiedLowering already knows that the input is a number.

    Bug: chromium:903043, v8:6882
    Change-Id: I0cb7c568029b461a92fc183104d5f359b4bfe7f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1328802
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#57382}

Refs: v8/v8@56f6a76
@BridgeAR BridgeAR requested a review from TimothyGu December 29, 2018 14:36
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 29, 2018

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2102/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Dec 29, 2018
TimothyGu
TimothyGu approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM.

@devsnek
Copy link
Member

devsnek commented Dec 29, 2018

just as a funny sidenote, we made the same mistake in node core :p #17507

mhdawson
mhdawson approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@addaleax
Copy link
Member

addaleax commented Jan 8, 2019 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19998/ ✅ (yellow)
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1992/ ✔️

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2019
@BridgeAR
Copy link
Member Author

BridgeAR commented Jan 9, 2019

Resumed yellow CI https://ci.nodejs.org/job/node-test-pull-request/20008/

danbev pushed a commit that referenced this pull request Jan 9, 2019
@BridgeAR @danbev
deps: cherry-pick 56f6a76 from upstream V8
ddbb7d7 
Original commit message:

    [turbofan] Fix -0 check for subnormals.

    Previously we'd check `x` for -0 by testing `(1.0 / x) == -Infinity`,
    but this will yield the wrong results when `x` is a subnormal, i.e.
    really close to 0.

    In CSA we already perform bit checks to test for -0, so teach TurboFan
    to do the same for comparisons to -0 (via `Object.is`). We introduce a
    new NumberIsMinusZero simplified operator to handle the case where
    SimplifiedLowering already knows that the input is a number.

    Bug: chromium:903043, v8:6882
    Change-Id: I0cb7c568029b461a92fc183104d5f359b4bfe7f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1328802
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57382}

PR-URL: #25269
Refs: v8/v8@56f6a76
Fixes: #25268
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
Copy link
Contributor

danbev commented Jan 9, 2019

Landed in ddbb7d7.

I updated the commit summary/subject to be deps: cherry-pick 56f6a76 from upstream V8 to avoid the issue reported by Travis CI, hope that was ok.

@danbev danbev closed this Jan 9, 2019
@addaleax
Copy link
Member

addaleax commented Jan 15, 2019 •
edited
Loading

@BridgeAR This would need a manual backport to v11.x-staging (it applies cleanly but does not compile)

@BridgeAR
Copy link
Member Author

BridgeAR commented Jan 16, 2019

@addaleax I would like to backport this and it lands cleanly on v11.x but it relies on some other code and I do not know the code base well enough to backport this on my own (see also #25270 (comment)).

It would be great if the @nodejs/v8-update could have a look at backporting this.

@targos targos mentioned this pull request Feb 6, 2019
Closed
@targos
Copy link
Member

targos commented Feb 14, 2019

Attempts to backport to v11 and v10:

This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the fix-weird-numbers-master branch January 20, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@mhdawson mhdawson mhdawson approved these changes

+3 more reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@devsnek devsnek devsnek approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Object.is(-Number.MIN_VALUE, -0) broken on ≥ v10.0.0