Skip to content

[v11.x] zlib: split JS code as prep for non-zlib-backed streams#25228

Closed
addaleax wants to merge 1 commit intonodejs:v11.x-stagingfrom
addaleax:backport-24939
Closed

[v11.x] zlib: split JS code as prep for non-zlib-backed streams#25228
addaleax wants to merge 1 commit intonodejs:v11.x-stagingfrom
addaleax:backport-24939

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Dec 26, 2018

Backport #24939 – only differences are the usage of util.inherits() vs direct prototype setting.

Split the Zlib class into ZlibBase and Zlib classes,
to facilitate introduction of similar streams with minor
implementation differences.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
zlib: split JS code as prep for non-zlib-backed streams
696e9bd 
Split the `Zlib` class into `ZlibBase` and `Zlib` classes,
to facilitate introduction of similar streams with minor
implementation differences.

PR-URL: nodejs#24939
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 26, 2018

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2069/pipeline

@nodejs-github-bot nodejs-github-bot added v11.x zlib Issues and PRs related to the zlib subsystem. labels Dec 26, 2018
@addaleax addaleax mentioned this pull request Dec 26, 2018
Closed
2 tasks
@addaleax
Copy link
Member Author

addaleax commented Dec 26, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19817/

@addaleax
Copy link
Member Author

addaleax commented Dec 30, 2018 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19873/ (green)

targos pushed a commit that referenced this pull request Jan 1, 2019
@addaleax @targos
zlib: split JS code as prep for non-zlib-backed streams
e534dcd 
Split the `Zlib` class into `ZlibBase` and `Zlib` classes,
to facilitate introduction of similar streams with minor
implementation differences.

Backport-PR-URL: #25228
PR-URL: #24939
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos
Copy link
Member

targos commented Jan 1, 2019

Landed in e534dcd. Thanks!

@targos targos closed this Jan 1, 2019
@addaleax addaleax deleted the backport-24939 branch May 13, 2019 18:44
addaleax added a commit that referenced this pull request May 13, 2019
@addaleax
zlib: split JS code as prep for non-zlib-backed streams
ebe51a4 
Split the `Zlib` class into `ZlibBase` and `Zlib` classes,
to facilitate introduction of similar streams with minor
implementation differences.

Backport-PR-URL: #25228
PR-URL: #24939
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@addaleax @MylesBorins
zlib: split JS code as prep for non-zlib-backed streams
dd8d1da 
Split the `Zlib` class into `ZlibBase` and `Zlib` classes,
to facilitate introduction of similar streams with minor
implementation differences.

Backport-PR-URL: #25228
PR-URL: #24939
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@addaleax @nodejs-github-bot @targos