test: make sure tmpdir is created before using it#25224
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
test: make sure tmpdir is created before using it#25224joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
Otherwise it throws ENOENT when the folder happens to be cleaned
benjamingr
approved these changes
Dec 26, 2018
richardlau
approved these changes
Dec 26, 2018
lundibundi
approved these changes
Dec 26, 2018
cjihrig
approved these changes
Dec 26, 2018
Member
|
👍 We should probably consider a lint rule that warns if you use |
lpinca
approved these changes
Dec 26, 2018
jasnell
approved these changes
Dec 27, 2018
joyeecheung
added
the
author ready
Member
Member
|
known flake failed - test-fs-realpath-pipe: #25070 Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19911/ |
Member
|
Landed in f131ea6 |
addaleax
pushed a commit
that referenced
this pull request
Jan 2, 2019
Otherwise it throws ENOENT when the folder happens to be cleaned PR-URL: #25224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jan 5, 2019
Otherwise it throws ENOENT when the folder happens to be cleaned PR-URL: #25224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Otherwise it throws ENOENT when the folder happens to be cleaned PR-URL: nodejs#25224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Otherwise it throws ENOENT when the folder happens to be cleaned PR-URL: nodejs#25224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
Otherwise it throws ENOENT when the folder happens to be cleaned PR-URL: #25224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Otherwise it throws ENOENT when the folder happens to be cleaned PR-URL: #25224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Otherwise it throws ENOENT when the folder happens to be cleaned PR-URL: #25224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it throws ENOENT when the folder happens to be cleaned
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes