Skip to content

[v8.x] http: add maxHeaderSize property#25218

Closed
MylesBorins wants to merge 1 commit intonodejs:v8.x-stagingfrom
MylesBorins:backport-httpHeaderSize-8.x
Closed

[v8.x] http: add maxHeaderSize property#25218
MylesBorins wants to merge 1 commit intonodejs:v8.x-stagingfrom
MylesBorins:backport-httpHeaderSize-8.x

Conversation

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Dec 25, 2018 

-      const { getOptionValue } = require('internal/options');
-      maxHeaderSize = getOptionValue('--max-http-header-size');
+      maxHeaderSize = process.binding('config').maxHTTPHeaderSize;

internal/options does not exist on 8.x or 6.x. As such maxHTTPHeaderSize is exposed on process.binding('config')

@cjihrig @MylesBorins
http: add maxHeaderSize property
e59cc49 
This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: nodejs#24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 25, 2018

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2063/pipeline

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v8.x labels Dec 25, 2018
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Dec 25, 2018

Mostly opening this for documentation purposes, will be landing without review as long as the basic CI passes

MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@cjihrig @MylesBorins
http: add maxHeaderSize property
c5142b3 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Dec 25, 2018

landed in c5142b3

MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@cjihrig @MylesBorins
http: add maxHeaderSize property
446f8b5 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@cjihrig @MylesBorins
http: add maxHeaderSize property
b69e096 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@cjihrig @MylesBorins
http: add maxHeaderSize property
c0c4de7 
This commit exposes the value of --max-http-header-size
as a property of the http module.

Backport-PR-URL: #25218
PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
mcollina
mcollina reviewed Dec 25, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax addaleax changed the title http: add maxHeaderSize property [v8.x] http: add maxHeaderSize property Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina left review comments

@cjihrig cjihrig Awaiting requested review from cjihrig

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MylesBorins @nodejs-github-bot @mcollina @cjihrig