src: set up process.nextTick and promise handlers with internalBinding('task_queue') by joyeecheung · Pull Request #25163 · nodejs/node

joyeecheung · 2018-12-21T10:49:27Z

Please use https://github.com/nodejs/node/pull/25163/files?w=1 to skip indentation changes

src: move symbols binding into node_symbols.cc

src: move process.nextTick and promise setup into node_task_queue.cc

This patch:

Moves the process.nextTick and promise setup C++ code into
node_task_queue.cc which is exposed as
internalBinding('task_queue')
Makes lib/internal/process/promises.js and
lib/internal/process/next_tick.js as side-effect-free
as possible
Removes the bootstrapper object being passed into
bootstrap/node.js, let next_tick.js and promises.js
load whatever they need from internalBinding('task_queue')
instead.
Rename process._tickCallback to runNextTicks internally
for clarity but still expose it as process._tickCallback.

Refs: #24961

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

This patch: - Moves the process.nextTick and promise setup C++ code into node_task_queue.cc which is exposed as `internalBinding('task_queue')` - Makes `lib/internal/process/promises.js` and `lib/internal/process/next_tick.js` as side-effect-free as possible - Removes the bootstrapper object being passed into `bootstrap/node.js`, let `next_tick.js` and `promises.js` load whatever they need from `internalBinding('task_queue')` instead. - Rename `process._tickCallback` to `runNextTicks` internally for clarity but still expose it as `process._tickCallback`.

nodejs-github-bot · 2018-12-21T10:49:30Z

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2024/pipeline

joyeecheung · 2018-12-21T10:50:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19713/

…eue.cc

joyeecheung · 2018-12-22T09:48:10Z

Fixed the test for --worker. CI: https://ci.nodejs.org/job/node-test-pull-request/19747/ ✔️

apapirovski

LGTM

joyeecheung · 2018-12-24T00:02:20Z

Landed in bcea74f...457603e, thanks!

PR-URL: #25163 Refs: #24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This patch: - Moves the process.nextTick and promise setup C++ code into node_task_queue.cc which is exposed as `internalBinding('task_queue')` - Makes `lib/internal/process/promises.js` and `lib/internal/process/next_tick.js` as side-effect-free as possible - Removes the bootstrapper object being passed into `bootstrap/node.js`, let `next_tick.js` and `promises.js` load whatever they need from `internalBinding('task_queue')` instead. - Rename `process._tickCallback` to `runNextTicks` internally for clarity but still expose it as `process._tickCallback`. PR-URL: #25163 Refs: #24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins · 2018-12-25T06:55:22Z

This doesn't land cleanly on v11.x, should it be backported?

PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This patch: - Moves the process.nextTick and promise setup C++ code into node_task_queue.cc which is exposed as `internalBinding('task_queue')` - Makes `lib/internal/process/promises.js` and `lib/internal/process/next_tick.js` as side-effect-free as possible - Removes the bootstrapper object being passed into `bootstrap/node.js`, let `next_tick.js` and `promises.js` load whatever they need from `internalBinding('task_queue')` instead. - Rename `process._tickCallback` to `runNextTicks` internally for clarity but still expose it as `process._tickCallback`. PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

PR-URL: #25163 Refs: #24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This patch: - Moves the process.nextTick and promise setup C++ code into node_task_queue.cc which is exposed as `internalBinding('task_queue')` - Makes `lib/internal/process/promises.js` and `lib/internal/process/next_tick.js` as side-effect-free as possible - Removes the bootstrapper object being passed into `bootstrap/node.js`, let `next_tick.js` and `promises.js` load whatever they need from `internalBinding('task_queue')` instead. - Rename `process._tickCallback` to `runNextTicks` internally for clarity but still expose it as `process._tickCallback`. PR-URL: #25163 Refs: #24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

addaleax · 2019-01-15T18:07:14Z

This applies cleanly now, apart from conflict resolution in parallel/test-bootstrap-modules (we should really do sth about that test…)

PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This patch: - Moves the process.nextTick and promise setup C++ code into node_task_queue.cc which is exposed as `internalBinding('task_queue')` - Makes `lib/internal/process/promises.js` and `lib/internal/process/next_tick.js` as side-effect-free as possible - Removes the bootstrapper object being passed into `bootstrap/node.js`, let `next_tick.js` and `promises.js` load whatever they need from `internalBinding('task_queue')` instead. - Rename `process._tickCallback` to `runNextTicks` internally for clarity but still expose it as `process._tickCallback`. PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This patch: - Moves the process.nextTick and promise setup C++ code into node_task_queue.cc which is exposed as `internalBinding('task_queue')` - Makes `lib/internal/process/promises.js` and `lib/internal/process/next_tick.js` as side-effect-free as possible - Removes the bootstrapper object being passed into `bootstrap/node.js`, let `next_tick.js` and `promises.js` load whatever they need from `internalBinding('task_queue')` instead. - Rename `process._tickCallback` to `runNextTicks` internally for clarity but still expose it as `process._tickCallback`. PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

joyeecheung added 2 commits December 21, 2018 18:43

src: move symbols binding into node_symbols.cc

62689e4

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 21, 2018

joyeecheung changed the title ~~src: move process.nextTick and promise setup into node_task_queue.cc~~ src: set up process.nextTick and promise handlers with internalBinding('task_queue') Dec 21, 2018

BridgeAR approved these changes Dec 21, 2018

View reviewed changes

fixup! src: move process.nextTick and promise setup into node_task_qu…

aae822d

…eue.cc

apapirovski approved these changes Dec 23, 2018

View reviewed changes

joyeecheung closed this Dec 24, 2018

joyeecheung added a commit that referenced this pull request Dec 24, 2018

src: move symbols binding into node_symbols.cc

e830e27

PR-URL: #25163 Refs: #24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins added the backport-requested-v11.x label Dec 25, 2018

refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019

src: move symbols binding into node_symbols.cc

700f58f

PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

addaleax pushed a commit that referenced this pull request Jan 15, 2019

src: move symbols binding into node_symbols.cc

733af61

PR-URL: #25163 Refs: #24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

addaleax removed the backport-requested-v11.x label Jan 15, 2019

BridgeAR mentioned this pull request Jan 16, 2019

v11.7.0 proposal #25537

Merged

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019

src: move symbols binding into node_symbols.cc

a9ea811

PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019

src: move symbols binding into node_symbols.cc

fa74cd3

PR-URL: nodejs#25163 Refs: nodejs#24961 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins mentioned this pull request Jan 24, 2019

v11.8.0 proposal #25687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

src: set up process.nextTick and promise handlers with internalBinding('task_queue')#25163

src: set up process.nextTick and promise handlers with internalBinding('task_queue')#25163
joyeecheung wants to merge 3 commits intonodejs:masterfrom
joyeecheung:task-queue

joyeecheung commented Dec 21, 2018 •

edited

Loading

Uh oh!

nodejs-github-bot commented Dec 21, 2018

Uh oh!

joyeecheung commented Dec 21, 2018

Uh oh!

joyeecheung commented Dec 22, 2018 •

edited by Trott

Loading

Uh oh!

apapirovski left a comment

Uh oh!

joyeecheung commented Dec 24, 2018

Uh oh!

MylesBorins commented Dec 25, 2018

Uh oh!

addaleax commented Jan 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

joyeecheung commented Dec 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

src: move symbols binding into node_symbols.cc

src: move process.nextTick and promise setup into node_task_queue.cc

Checklist

Uh oh!

nodejs-github-bot commented Dec 21, 2018

Uh oh!

joyeecheung commented Dec 21, 2018

Uh oh!

joyeecheung commented Dec 22, 2018 • edited by Trott Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

apapirovski left a comment

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Dec 24, 2018

Uh oh!

MylesBorins commented Dec 25, 2018

Uh oh!

addaleax commented Jan 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

joyeecheung commented Dec 21, 2018 •

edited

Loading

joyeecheung commented Dec 22, 2018 •

edited by Trott

Loading