fs: remove use less internalFS#25161
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:fs-remove-use-less-internal-fs
Closed
fs: remove use less internalFS#25161ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:fs-remove-use-less-internal-fs
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:fs-remove-use-less-internal-fs
Conversation
nodejs-github-bot
added
the
fs
targos
approved these changes
Dec 21, 2018
lpinca
approved these changes
Dec 21, 2018
cjihrig
approved these changes
Dec 21, 2018
tniessen
approved these changes
Dec 23, 2018
jasnell
approved these changes
Dec 27, 2018
Member
Member
|
Landed in 3681ddd. |
pull bot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
Feb 9, 2019
PR-URL: nodejs#25161 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 10, 2019
PR-URL: #25161 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internalFSis just used once in the wholefs.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes