Remove dead TLS code, and fix some misnamed variables by sam-github · Pull Request #25153 · nodejs/node

sam-github · 2018-12-20T17:18:56Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-12-20T17:18:58Z

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2019/pipeline

sam-github · 2018-12-21T23:12:24Z

ci: https://ci.nodejs.org/job/node-test-pull-request/19730/

sam-github · 2018-12-21T23:12:41Z

@nodejs/crypto

sam-github · 2018-12-27T18:42:16Z

ci: https://ci.nodejs.org/job/node-test-pull-request/19842/

The OCSP info from parsing the TLS ClientHello has not been used since 550c263, remove it. See: nodejs#1464

"wrapped" argument is the caller's "socket", not its "wrap", and its referred to as "socket" in the comments, so call it that.

Don't use "socket" to describe two different objects in the same function.

session ID was named session in C++ and key in JS, Name them after what they are, as the 'newSession' event docs do.

Its confusing to call a js class with a handle a "Wrap", usually it's the C++ handle that is called a Wrap (tcp_wrap, tls_wrap, ...). Its derived from Socket, and makes a JS stream look like a Socket, so call it that. Also, remove use of lib/_stream_wrap.js so it can be deprecated some time.

sam-github · 2018-12-27T22:48:21Z

ci: https://ci.nodejs.org/job/node-test-pull-request/19847/

Last ci failed on one windows machine. Maybe ephemeral. Also, hard to read the logs to figure out why. Now its rebased on #25148 the log should be more readable if it does fail, so trying again.

sam-github · 2018-12-28T17:03:34Z

Everything green except https://ci.nodejs.org/job/node-test-commit-freebsd/23089/, test.parallel/test-fs-read-stream-concurrent-reads, can't see how that is related to tls code removal.

rebuild: https://ci.nodejs.org/job/node-test-commit-freebsd/23102/

sam-github · 2018-12-28T20:58:52Z

Landed in acb49dc...00944c7

freebsd passed

The OCSP info from parsing the TLS ClientHello has not been used since 550c263, remove it. See: #1464 PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

"wrapped" argument is the caller's "socket", not its "wrap", and its referred to as "socket" in the comments, so call it that. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Don't use "socket" to describe two different objects in the same function. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

session ID was named session in C++ and key in JS, Name them after what they are, as the 'newSession' event docs do. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Its confusing to call a js class with a handle a "Wrap", usually it's the C++ handle that is called a Wrap (tcp_wrap, tls_wrap, ...). Its derived from Socket, and makes a JS stream look like a Socket, so call it that. Also, remove use of lib/_stream_wrap.js so it can be deprecated some time. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

The OCSP info from parsing the TLS ClientHello has not been used since 550c263, remove it. See: #1464 PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

"wrapped" argument is the caller's "socket", not its "wrap", and its referred to as "socket" in the comments, so call it that. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

session ID was named session in C++ and key in JS, Name them after what they are, as the 'newSession' event docs do. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Its confusing to call a js class with a handle a "Wrap", usually it's the C++ handle that is called a Wrap (tcp_wrap, tls_wrap, ...). Its derived from Socket, and makes a JS stream look like a Socket, so call it that. Also, remove use of lib/_stream_wrap.js so it can be deprecated some time. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Its unused by node, and doesn't have a reasonable use outside of node. See: nodejs#25153 See: nodejs#16158

Its unused by node, and doesn't have a reasonable use outside of node. See: #25153 See: #16158 PR-URL: #26245 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Don't use "socket" to describe two different objects in the same function. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

"wrapped" argument is the caller's "socket", not its "wrap", and its referred to as "socket" in the comments, so call it that. PR-URL: nodejs#25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

session ID was named session in C++ and key in JS, Name them after what they are, as the 'newSession' event docs do. PR-URL: nodejs#25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Its confusing to call a js class with a handle a "Wrap", usually it's the C++ handle that is called a Wrap (tcp_wrap, tls_wrap, ...). Its derived from Socket, and makes a JS stream look like a Socket, so call it that. Also, remove use of lib/_stream_wrap.js so it can be deprecated some time. PR-URL: nodejs#25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

The OCSP info from parsing the TLS ClientHello has not been used since 550c263, remove it. See: nodejs#1464 PR-URL: nodejs#25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Don't use "socket" to describe two different objects in the same function. PR-URL: #25153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 20, 2018

sam-github force-pushed the tls-cleanups-1 branch from 4c9f10a to 3c4e3cc Compare December 20, 2018 17:20

addaleax approved these changes Dec 21, 2018

View reviewed changes

tniessen approved these changes Dec 22, 2018

View reviewed changes

jasnell approved these changes Dec 27, 2018

View reviewed changes

apapirovski approved these changes Dec 27, 2018

View reviewed changes

sam-github added 5 commits December 27, 2018 14:40

tls: remove unused ocsp extension parsing

dd12dc9

The OCSP info from parsing the TLS ClientHello has not been used since 550c263, remove it. See: nodejs#1464

tls: fix initRead socket argument name

f309cec

"wrapped" argument is the caller's "socket", not its "wrap", and its referred to as "socket" in the comments, so call it that.

tls: do not confuse TLSSocket and Socket

2e526ce

Don't use "socket" to describe two different objects in the same function.

tls: do not confuse session and session ID

c25afe9

session ID was named session in C++ and key in JS, Name them after what they are, as the 'newSession' event docs do.

sam-github force-pushed the tls-cleanups-1 branch from 3c4e3cc to fe15429 Compare December 27, 2018 22:41

sam-github closed this Dec 28, 2018

sam-github deleted the tls-cleanups-1 branch December 28, 2018 20:58

sam-github added a commit to sam-github/node that referenced this pull request Mar 2, 2019

lib: deprecate _stream_wrap

a1fb336

Its unused by node, and doesn't have a reasonable use outside of node. See: nodejs#25153 See: nodejs#16158

sam-github mentioned this pull request Apr 26, 2019

[v10.x backport] TLS1.3 (and dependent PRs) #27432

Closed

BethGriggs mentioned this pull request May 1, 2019

v10.16.0 proposal #27514

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove dead TLS code, and fix some misnamed variables#25153

Remove dead TLS code, and fix some misnamed variables#25153
sam-github wants to merge 5 commits intonodejs:masterfrom
sam-github:tls-cleanups-1

sam-github commented Dec 20, 2018 •

edited

Loading

Uh oh!

nodejs-github-bot commented Dec 20, 2018

Uh oh!

sam-github commented Dec 21, 2018

Uh oh!

sam-github commented Dec 21, 2018

Uh oh!

sam-github commented Dec 27, 2018

Uh oh!

sam-github commented Dec 27, 2018

Uh oh!

sam-github commented Dec 28, 2018

Uh oh!

sam-github commented Dec 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

sam-github commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Dec 20, 2018

Uh oh!

sam-github commented Dec 21, 2018

Uh oh!

sam-github commented Dec 21, 2018

Uh oh!

sam-github commented Dec 27, 2018

Uh oh!

sam-github commented Dec 27, 2018

Uh oh!

sam-github commented Dec 28, 2018

Uh oh!

sam-github commented Dec 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sam-github commented Dec 20, 2018 •

edited

Loading