Skip to content

lib: minor cleanup#25149

Closed
BridgeAR wants to merge 4 commits intonodejs:masterfrom
BridgeAR:remove-obsolete-call
Closed

lib: minor cleanup#25149
BridgeAR wants to merge 4 commits intonodejs:masterfrom
BridgeAR:remove-obsolete-call

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Dec 20, 2018

Just two minor things I stumbled upon while looking at other things.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

addaleax
addaleax approved these changes Dec 20, 2018
View reviewed changes
@BridgeAR BridgeAR force-pushed the remove-obsolete-call branch from 2c91690 to 3ceea0a Compare December 23, 2018 17:13
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 23, 2018 •
edited
Loading

PTAL

I moved the types part into the bootstrapping part. That seemed like the most natural place for it.

CI https://ci.nodejs.org/job/node-test-pull-request/19761/
CI https://ci.nodejs.org/job/node-test-pull-request/19762/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 23, 2018
@BridgeAR
bootstrap: make sure all type checks exist early
21c0a0e 
Combine all type checks on the internal types binding during
bootstrapping. This makes sure all of those checks exist early on
and not only after loading the util module.
@BridgeAR
console: use spread notation instead of Object.assign
8c06fd3
@BridgeAR BridgeAR force-pushed the remove-obsolete-call branch from 3ceea0a to 8c06fd3 Compare December 23, 2018 17:16
@Trott
Copy link
Member

Trott commented Dec 23, 2018

CI failures are sufficiently extensive that I'm going to remove the author ready label. Feel free to re-add it as soon as appropriate. Not objecting. Just keeping it out of my search results until it's actually ready. :-D

@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 23, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 23, 2018 •
edited by Trott
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/19770/ ✔️

devsnek
devsnek reviewed Dec 23, 2018
View reviewed changes
@BridgeAR
fixup: refactor internal types
394bfb9 
Now all type checks should be required loading 'internal/util/types'.
@Trott
Copy link
Member

Trott commented Dec 24, 2018 •
edited
Loading

Post fixup commit CI: https://ci.nodejs.org/job/node-test-pull-request/19777/ ✔️

@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 27, 2018

@lpinca @addaleax @devsnek PTAL (I changed the code significantly enough that confirming the LG would be good).

@lpinca
Copy link
Member

lpinca commented Dec 27, 2018

Still LGTM.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 27, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 27, 2018
@BridgeAR
lib: expose all type checks from the internal types module
5ac30c9 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 27, 2018
@BridgeAR
console: use spread notation instead of Object.assign
4ea2c1c 
PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 27, 2018

Landed in 5ac30c9 and 4ea2c1c

@BridgeAR BridgeAR closed this Dec 27, 2018
targos pushed a commit that referenced this pull request Jan 1, 2019
@BridgeAR @targos
console: use spread notation instead of Object.assign
561c268 
PR-URL: #25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@addaleax
Copy link
Member

addaleax commented Jan 5, 2019

The lib: commit does not apply cleanly, so:

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 9, 2019
@BridgeAR
lib: expose all type checks from the internal types module
4788625 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 9, 2019
Closed
4 tasks
BridgeAR added a commit that referenced this pull request Jan 10, 2019
@BridgeAR
lib: expose all type checks from the internal types module
e97acf7 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: #25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
@BridgeAR @joyeecheung
lib: expose all type checks from the internal types module
7d90f03 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@BridgeAR @addaleax
lib: expose all type checks from the internal types module
6528ce6 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: #25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>

Backport-PR-URL: #25446
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
lib: expose all type checks from the internal types module
476c4ef 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
console: use spread notation instead of Object.assign
fcd2523 
PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@BridgeAR
lib: expose all type checks from the internal types module
27b8585 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>

Backport-PR-URL: nodejs#25446
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@BridgeAR BridgeAR deleted the remove-obsolete-call branch January 20, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

+2 more reviewers

@devsnek devsnek devsnek left review comments

@lundibundi lundibundi lundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BridgeAR @Trott @lpinca @addaleax @jasnell @devsnek @lundibundi