test: add stdout check to test-esm-cjs-main#25073
Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Closed
test: add stdout check to test-esm-cjs-main#25073Trott wants to merge 2 commits intonodejs:masterfrom
Trott wants to merge 2 commits intonodejs:masterfrom
Conversation
Member
Author
richardlau
approved these changes
Dec 16, 2018
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
LGTM if we rename the parameter.
Member
Author
Trott
added
the
author ready
antsmartian
approved these changes
Dec 16, 2018
Member
Author
|
Note to whoever lands this (which will probably be me): The commit message needs to be edited as it's checking |
cjihrig
approved these changes
Dec 16, 2018
Member
Author
|
Only red in the CI seems to be because the cleanup detected that @gireeshpunathil was testing something on CI: 21:45:21 ps awwx | grep Release/node | grep -v grep | cat
21:45:21 32506076 pts/2 A 0:00 /home/iojs/gireesh/exitrace/node/out/Release/node -e console.log('foobar');
21:45:21 gmake[1]: *** [test-ci] Error 1If we see this happening a lot, we'll mark the node offline in Jenkins while they're doing their work (which is something we should do anyway, but we'd need some pretty responsive/on-duty Build folks to oversee it because right now we have them on one AIX node and @gabrielschulhof working on the other, so we'd have no AIX nodes left online potentially). TL;DR Red CI here is unrelated and we'll Resume Build anyway. |
Member
Author
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19585/ ✔️ |
watilde
approved these changes
Dec 16, 2018
lpinca
approved these changes
Dec 16, 2018
jasnell
approved these changes
Dec 17, 2018
Member
Author
|
Landed in dbdfc5d |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 18, 2018
PR-URL: nodejs#25073 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
PR-URL: #25073 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#25073 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
PR-URL: #25073 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
PR-URL: #25073 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
PR-URL: #25073 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes