doc: add codebytere's info to release team#25022
Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:add-codebytere-to-release
Closed
doc: add codebytere's info to release team#25022codebytere wants to merge 1 commit intonodejs:masterfrom codebytere:add-codebytere-to-release
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:add-codebytere-to-release
Conversation
cjihrig
approved these changes
Dec 13, 2018
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but can you follow the existing sort order.
richardlau
reviewed
Dec 13, 2018
MylesBorins
approved these changes
Dec 13, 2018
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
LGTM once order nit is fixed.
Fast track?
MylesBorins
added
the
fast-track
Contributor
|
Should we fast track? 👍🏽yes |
Contributor
richardlau
reviewed
Dec 13, 2018
|
|
||
| ```shell | ||
| gpg --keyserver pool.sks-keyservers.net --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C | ||
| gpg --keyserver pool.sks-keyservers.net --recv-keys B9E2F5981AA6E0CD28160D9FF13993A75599653C |
Member
There was a problem hiding this comment.
Anyone know if the order of the gpg keys here matter?
Fishrock123
suggested changes
Dec 13, 2018
|
|
||
| ```shell | ||
| gpg --keyserver pool.sks-keyservers.net --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C | ||
| gpg --keyserver pool.sks-keyservers.net --recv-keys B9E2F5981AA6E0CD28160D9FF13993A75599653C |
Contributor
There was a problem hiding this comment.
I can't find this key. Additionally, not required but maybe helpful, could be to use a keybase synced key.
Member
Author
There was a problem hiding this comment.
I published it to that keyserver earlier today; maybe it hasn't synced up quite yet? Also synced it up to keybase
Fishrock123
approved these changes
Dec 13, 2018
Contributor
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
Looks like pool.sks-keyservers.net has it now.
Member
|
Landed in 69a7a04 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 14, 2018
PR-URL: nodejs#25022 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
PR-URL: #25022 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#25022 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #25022 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
PR-URL: #25022 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #25022 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds my GPG key and name to list of trusted releasers.
/cc @MylesBorins
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes