stream: re-use existing once() implementation#24991
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
stream: re-use existing once() implementation#24991addaleax wants to merge 2 commits intonodejs:masterfrom
once() implementation#24991addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
BridgeAR
approved these changes
Dec 12, 2018
| return function(err) { | ||
| if (called) return; | ||
| called = true; | ||
| callback.call(this, err); |
Member
There was a problem hiding this comment.
It seems like the callback has a different context in once from internal/util. Is this something we want to pay attention to / align the behavior?
Member
Author
There was a problem hiding this comment.
Yeah, thanks – I’ve made the one in internal/util more generic 👍
Member
BridgeAR
added
the
author ready
lpinca
approved these changes
Dec 12, 2018
antsmartian
approved these changes
Dec 12, 2018
Fishrock123
approved these changes
Dec 12, 2018
Member
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
PR-URL: nodejs#24991 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Member
|
Landed in c9a7088 |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
PR-URL: #24991 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24991 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24991 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
PR-URL: #24991 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24991 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes