src: include node_internals.h in node_metadata.cc#24933
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
src: include node_internals.h in node_metadata.cc#24933danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
Currently, if configured --without-ssl the following compiler error will
be generated:
../src/node_metadata.cc:29:12:
error: use of undeclared identifier 'llhttp_version'
llhttp = llhttp_version;
^
../src/node_metadata.cc:30:17:
error: use of undeclared identifier 'http_parser_version'
http_parser = http_parser_version;
This commit includes the node_internals.h header so that
llhttp_version and http_parser_versions are always available.
nodejs-github-bot
added
the
c++
Contributor
Author
bnoordhuis
approved these changes
Dec 10, 2018
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
In case anyone else is confused why it worked with crypto enabled:
- node_metadata.cc includes node_crypto.h when
defined(HAVE_OPENSSL) - node_crypto.h includes async_wrap-inl.h
- async_wrap-inl.h includes node_internals.h
Member
|
CI failure is #24403. |
richardlau
approved these changes
Dec 10, 2018
joyeecheung
approved these changes
Dec 10, 2018
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM as a quick remedy, although I think we can simply move the definition of crypto::GetOpenSSLVersion here as it's not used elsewhere? Then all we need is openssl/opensslv.h here.
cjihrig
approved these changes
Dec 10, 2018
addaleax
approved these changes
Dec 10, 2018
Member
addaleax
added
the
author ready
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19394/ ✔️ |
BridgeAR
approved these changes
Dec 12, 2018
Contributor
Author
|
Landed in 549761e. |
danbev
added a commit
that referenced
this pull request
Dec 13, 2018
Currently, if configured --without-ssl the following compiler error will
be generated:
../src/node_metadata.cc:29:12:
error: use of undeclared identifier 'llhttp_version'
llhttp = llhttp_version;
^
../src/node_metadata.cc:30:17:
error: use of undeclared identifier 'http_parser_version'
http_parser = http_parser_version;
This commit includes the node_internals.h header so that
llhttp_version and http_parser_versions are always available.
PR-URL: #24933
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 17, 2018
Currently, if configured --without-ssl the following compiler error will
be generated:
../src/node_metadata.cc:29:12:
error: use of undeclared identifier 'llhttp_version'
llhttp = llhttp_version;
^
../src/node_metadata.cc:30:17:
error: use of undeclared identifier 'http_parser_version'
http_parser = http_parser_version;
This commit includes the node_internals.h header so that
llhttp_version and http_parser_versions are always available.
PR-URL: #24933
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
2 tasks
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Currently, if configured --without-ssl the following compiler error will
be generated:
../src/node_metadata.cc:29:12:
error: use of undeclared identifier 'llhttp_version'
llhttp = llhttp_version;
^
../src/node_metadata.cc:30:17:
error: use of undeclared identifier 'http_parser_version'
http_parser = http_parser_version;
This commit includes the node_internals.h header so that
llhttp_version and http_parser_versions are always available.
PR-URL: nodejs#24933
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if configured
--without-sslthe following compiler error willbe generated:
This commit includes the node_internals.h header so that
llhttp_version and http_parser_versions are always available.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes