lib: extract validateObject validator#24920
Closed
ZYSzys wants to merge 3 commits intonodejs:masterfrom
zys-contrib:validate-object
Closed
lib: extract validateObject validator#24920ZYSzys wants to merge 3 commits intonodejs:masterfrom zys-contrib:validate-object
ZYSzys wants to merge 3 commits intonodejs:masterfrom
zys-contrib:validate-object
Conversation
BridgeAR
reviewed
Dec 9, 2018
Contributor
|
FWIW this conflicts with #24913 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls out the common argument
validateObjectvalidator to internal/validators.BTW, there is inconsistent
ERR_INVALID_ARG_TYPEvia theobjectvalidation:objectorObject, do we need to unify this error message ? Although this is so trivial :)node/lib/path.js
Line 896 in 951b1c3
node/lib/child_process.js
Line 408 in 951b1c3
Update: unify the error message by lowercase
object(should be semver-major?)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes