src: remove unused env variables in node_util#24820
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove unused env variables in node_util#24820danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
Currently the following compiler warnings are generated:
../src/node_util.cc:59:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
../src/node_util.cc:78:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
2 warnings generated.
This commit removes the two unused variables.
nodejs-github-bot
added
c++
Contributor
Author
sam-github
approved these changes
Dec 4, 2018
Contributor
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
LGTM, good luck getting it through ci! :-)
richardlau
approved these changes
Dec 4, 2018
Contributor
Author
I got lucky this time :) |
cjihrig
approved these changes
Dec 4, 2018
Fishrock123
approved these changes
Dec 4, 2018
lpinca
approved these changes
Dec 4, 2018
2 tasks
Contributor
Author
|
Landed in 59b46a4. |
pull bot
pushed a commit
to SimenB/node
that referenced
this pull request
Dec 7, 2018
Currently the following compiler warnings are generated:
../src/node_util.cc:59:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
../src/node_util.cc:78:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
2 warnings generated.
This commit removes the two unused variables.
PR-URL: nodejs#24820
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 7, 2018
Currently the following compiler warnings are generated:
../src/node_util.cc:59:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
../src/node_util.cc:78:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
2 warnings generated.
This commit removes the two unused variables.
PR-URL: #24820
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Currently the following compiler warnings are generated:
../src/node_util.cc:59:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
../src/node_util.cc:78:16:
warning: unused variable 'env' [-Wunused-variable]
Environment* env = Environment::GetCurrent(args);
^
2 warnings generated.
This commit removes the two unused variables.
PR-URL: nodejs#24820
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the following compiler warnings are generated:
This commit removes the two unused variables.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes