timers: truncate decimal values by Fishrock123 · Pull Request #24819 · nodejs/node

Fishrock123 · 2018-12-04T01:57:19Z

Reverts some timers behavior back to as it was before 2930bd1.

That commit introduced an unintended change which allowed non-integer timeouts to actually exist since the value is no longer converted to an integer via a TimeWrap handle directly.

Even with the fix in e9de435 non-integer timeouts are still indeterministic, because libuv does not support them.

This fixes the issue by emulating the old behavior: truncate the _idleTimeout before using it.

See comments in #24214 for more background on this.

In hindsight, I actually think this discovery makes 2930bd1 semver-major. I think that commit has perhaps spread too far to just 'undo' it, so I think reverting the behavior (not necessarily the code) is the best choice of action.

Note: libuv doesn't even support non-integer / sub-millisecond timers so really we can't even support sub-millisecond timers (the only real use for non-integer timeouts).
(I don't think supporting sub-millisecond timers is particularly useful, either.)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-12-04T01:57:21Z

@Fishrock123 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1817/pipeline

Fishrock123 · 2018-12-04T02:30:48Z

cc @nodejs/timers

CI: https://ci.nodejs.org/job/node-test-pull-request/19172/

test/parallel/test-timers-non-integer-delay.js

apapirovski · 2018-12-04T03:17:52Z

Approved but there might be a few edge cases that I need to test. Will let you know. If possible, please avoid merging until then.

bnoordhuis · 2018-12-04T11:20:54Z

libuv doesn't even support non-integer / sub-millisecond timers

Adding a uv_hrtimer_t handle type isn't out of the question, if there is a need for it.

Fishrock123 · 2018-12-04T17:39:18Z

libuv doesn't even support non-integer / sub-millisecond timers

Adding a uv_hrtimer_t handle type isn't out of the question, if there is a need for it.

Right, but we probably want to have that discussion elsewhere (if we want to have it), since there is some broken behavior in here currently.

apapirovski · 2018-12-07T03:13:59Z

I’m going to be testing the issue I have in mind tomorrow.

apapirovski · 2018-12-07T03:15:31Z

In hindsight, I actually think this discovery makes 2930bd1 semver-major. I think that commit has perhaps spread too far to just 'undo' it, so I think reverting the behavior (not necessarily the code) is the best choice of action.

That commit is semver-major afaik. Not sure I follow.

danbev · 2018-12-07T04:50:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19295/

danbev · 2018-12-11T04:47:28Z

Re-run of failing node-test-commit-osx

Fishrock123 · 2018-12-11T05:24:57Z

@apapirovski did you get around to testing it?

apapirovski · 2018-12-13T04:19:47Z

@Fishrock123 you need to make sure that any time something like lists[item._idleTimeout] occurs, we use the truncated value. So line 384, needs to be lists[Math.trunc(item._idleTimeout)]. Then the behavior should be good. I'm going to spot check if any other places are affected.

Fishrock123 · 2018-12-13T19:57:59Z

@apapirovski Done, looks like just covering that spot is good enough. New CI: https://ci.nodejs.org/job/node-test-pull-request/19491/

(guess I maybe should add a test for that case though..)

TimothyGu · 2018-12-13T20:02:28Z

Potentially dumb question: why don't we truncate during setTimeout() or setInterval()?

Fishrock123 · 2018-12-14T01:34:06Z

@TimothyGu not dumb. The reason is that the timer api is... well... a bit too flexible due to historic reasons, so this way more reliably catches what a user could feed in.

One day, probably a year or so after active() is deprecated, this will no longer be an issue, hopefully.

Fishrock123 · 2018-12-19T02:26:26Z

test.parallel/test-child-process-execfile failed on nodes=alpine-latest-x64, I don't know why but as far as I am aware there aren't any other tests with non-decimal timeouts.

assert.js:753
    throw newErr;
    ^

AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Command failed: /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-latest-x64/out/Release/node /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-latest-x64/test/fixtures/exit.js 0

    at ChildProcess.exithandler (child_process.js:294:12)
    at ChildProcess.emit (events.js:189:13)
    at maybeClose (internal/child_process.js:978:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)

Fishrock123 · 2019-01-23T23:50:14Z

~~Another rebase + CI. Hopefully everything is more stable this time around.~~

~~https://ci.nodejs.org/job/node-test-pull-request/20295/~~

Edit: again, after rebase to pull in more test fixes https://ci.nodejs.org/job/node-test-pull-request/20378/

Reverts some timers behavior back to as it was before 2930bd1 That commit introduced an unintended change which allowed non-integer timeouts to actually exist since the value is no longer converted to an integer via a TimeWrap handle directly. Even with the fix in e9de435 non-integer timeouts are still indeterministic, because libuv does not support them. This fixes the issue by emulating the old behavior: truncate the `_idleTimeout` before using it. See comments in nodejs#24214 for more background on this.

Fishrock123 · 2019-01-29T00:25:43Z

Landed in a7c66b6

Reverts some timers behavior back to as it was before 2930bd1 That commit introduced an unintended change which allowed non-integer timeouts to actually exist since the value is no longer converted to an integer via a TimeWrap handle directly. Even with the fix in e9de435 non-integer timeouts are still indeterministic, because libuv does not support them. This fixes the issue by emulating the old behavior: truncate the `_idleTimeout` before using it. See comments in #24214 for more background on this. PR-URL: #24819 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Dec 4, 2018

Fishrock123 requested a review from apapirovski December 4, 2018 01:57

Fishrock123 force-pushed the timers-non-integer-delay branch from a0b2aa4 to 77d6fdf Compare December 4, 2018 02:00

richardlau reviewed Dec 4, 2018

View reviewed changes

test/parallel/test-timers-non-integer-delay.js Outdated Show resolved Hide resolved

apapirovski approved these changes Dec 4, 2018

View reviewed changes

addaleax approved these changes Dec 4, 2018

View reviewed changes

Fishrock123 mentioned this pull request Dec 4, 2018

flaky: sequential/test-cli-syntax-* #24403

Closed

Fishrock123 force-pushed the timers-non-integer-delay branch from 77d6fdf to 387130e Compare December 4, 2018 17:51

BridgeAR approved these changes Dec 4, 2018

View reviewed changes

joyeecheung mentioned this pull request Dec 5, 2018

CI failures: 20181201-20181205 nodejs/reliability#19

Closed

richardlau mentioned this pull request Dec 7, 2018

setTimeout eating CPU time and doing infinity stuck with non-whole delay #24897

Closed

trivikr approved these changes Dec 8, 2018

View reviewed changes

Fishrock123 force-pushed the timers-non-integer-delay branch from 387130e to 4c0f21e Compare December 13, 2018 19:56

jasnell approved these changes Dec 15, 2018

View reviewed changes

Fishrock123 force-pushed the timers-non-integer-delay branch from 4c0f21e to 9c7c99e Compare January 14, 2019 19:05

This comment has been minimized.

Sign in to view

This was referenced Jan 16, 2019

CI failures: 20190110 - 20190116 nodejs/reliability#20

Closed

Investigate flaky known_issues/test-vm-timeout-escape-queuemicrotask #25529

Closed

Fishrock123 force-pushed the timers-non-integer-delay branch from 9c7c99e to 339e7b8 Compare January 23, 2019 23:49

Fishrock123 force-pushed the timers-non-integer-delay branch from 339e7b8 to 10e70b6 Compare January 28, 2019 17:08

Fishrock123 closed this Jan 29, 2019

Fishrock123 deleted the timers-non-integer-delay branch January 29, 2019 00:25

targos mentioned this pull request Jan 29, 2019

v11.9.0 proposal #25802

Merged

Uh oh!

Conversation

Fishrock123 commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Dec 4, 2018

Uh oh!

Fishrock123 commented Dec 4, 2018

Uh oh!

Uh oh!

apapirovski commented Dec 4, 2018

Uh oh!

bnoordhuis commented Dec 4, 2018

Uh oh!

Fishrock123 commented Dec 4, 2018

Uh oh!

apapirovski commented Dec 7, 2018

Uh oh!

apapirovski commented Dec 7, 2018

Uh oh!

danbev commented Dec 7, 2018

Uh oh!

danbev commented Dec 11, 2018

Uh oh!

Fishrock123 commented Dec 11, 2018

Uh oh!

apapirovski commented Dec 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fishrock123 commented Dec 13, 2018

Uh oh!

TimothyGu commented Dec 13, 2018

Uh oh!

Fishrock123 commented Dec 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fishrock123 commented Dec 19, 2018

Uh oh!

This comment has been minimized.

Fishrock123 commented Jan 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fishrock123 commented Jan 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Fishrock123 commented Dec 4, 2018 •

edited

Loading

apapirovski commented Dec 13, 2018 •

edited

Loading

Fishrock123 commented Dec 14, 2018 •

edited

Loading

Fishrock123 commented Jan 23, 2019 •

edited

Loading