inspector, tracing: Make sure messages are sent on a main thread#24814
Merged
eugeneo merged 0 commit intonodejs:masterfrom Jan 30, 2019
eugeneo:23185-tracing-crash
Merged
inspector, tracing: Make sure messages are sent on a main thread#24814eugeneo merged 0 commit intonodejs:masterfrom eugeneo:23185-tracing-crash
eugeneo merged 0 commit intonodejs:masterfrom
eugeneo:23185-tracing-crash
Conversation
Contributor
Author
|
@ofrobots |
Contributor
Member
Contributor
Author
|
Looks like there's a race condition that surfaces on Windows. |
This was referenced Dec 5, 2018
Contributor
Author
|
CI is now passing: https://ci.nodejs.org/job/node-test-pull-request/19946/ I will update the commit title and will rebase the change. I also have a follow-up CL that fixes the problem that the bad test case identified. |
Member
|
@nodejs/v8-inspector @nodejs/trace-events |
Contributor
|
Any news on when this PR could be merged (as well was #24945) ? Currently the inspector based |
jasnell
approved these changes
Jan 28, 2019
Contributor
Author
Contributor
Author
|
The only CI failure is coming from a flaky test that only fails on a single bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #23185
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes