repl: revert multiline history by BridgeAR · Pull Request #24804 · nodejs/node

BridgeAR · 2018-12-03T13:47:19Z

So far the multiline history caused a lot of problems and the current logic is not suitable at all as such. It changes the actual content of the history and should not be used at all.

I struggle a lot with my history at the moment as it often forgets entries and similar and until a proper solution is found this should be reverted.

We discussed some possibilities how to properly implement this feature in #24231.

Refs: #24231

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-12-03T13:47:21Z

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1801/pipeline

antsmartian · 2018-12-03T13:57:02Z

@BridgeAR Agree with you. We can revisit this idea with the ideas suggested on the issue tracker.

antsmartian · 2018-12-03T14:05:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19150/

addaleax · 2018-12-03T18:28:29Z

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19158/

BridgeAR · 2018-12-04T11:20:48Z

Please +1 to fast track this.

addaleax · 2018-12-04T11:28:47Z

This doesn’t really seem suitable for fast-tracking? Is there a specific reason for doing so?

BridgeAR · 2018-12-04T11:35:56Z

@addaleax I want to prepare the next 11.x release and I would like to include this PR in that release. Since the feature is clearly broken (there were multiple bug reports about it), I don't see why this should not be suitable?

addaleax · 2018-12-04T11:39:03Z

@BridgeAR I trust you to make that call if you are sure about it, but generally, removing methods from a class that is public API is not exactly what we usually fast-track? If this is really broken, then yeah, I guess you can go ahead 👍

addaleax · 2018-12-05T16:05:11Z

@BridgeAR Looks like this needs a rebase?

This reverts commit eb42c1e.

This reverts commit dd7a3d2.

BridgeAR · 2018-12-05T17:26:25Z

Rebased

CI https://ci.nodejs.org/job/node-test-pull-request/19232/

danbev · 2018-12-06T04:17:53Z

Re-run of failing node-test-commit-windows-fanned ✔️

Trott · 2018-12-06T07:36:33Z

Landed in aa943d0...b1ada6c

This reverts commit eb42c1e. PR-URL: nodejs#24804 Refs: nodejs#24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This reverts commit dd7a3d2. PR-URL: nodejs#24804 Refs: nodejs#24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This reverts commit eb42c1e. PR-URL: #24804 Refs: #24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This reverts commit dd7a3d2. PR-URL: #24804 Refs: #24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Notable Changes: * console,util: * `console` functions now handle symbols as defined in the spec. #23708 * The inspection `depth` default is now back at 2. #24326 * dgram,net: * Added ipv6Only option for `net` and `dgram`. #23798 * http: * Chosing between the http parser is now possible per runtime flag. #24739 * readline: * The `readline` module now supports async iterators. #23916 * repl: * The multiline history feature is removed. #24804 * tls: * Added min/max protocol version options. #24405 * The X.509 public key info now includes the RSA bit size and the elliptic curve. #24358 * url: * `pathToFileURL()` now supports LF, CR and TAB. #23720 * Windows: * Tools are not installed using Boxstarter anymore. #24677 * The install-tools scripts or now included in the dist. #24233 * Added new collaborator: * [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655 PR-URL: #24854

This reverts commit eb42c1e. PR-URL: #24804 Refs: #24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This reverts commit dd7a3d2. PR-URL: #24804 Refs: #24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This reverts commit eb42c1e. PR-URL: #24804 Refs: #24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This reverts commit dd7a3d2. PR-URL: #24804 Refs: #24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Notable Changes: * console,util: * `console` functions now handle symbols as defined in the spec. #23708 * The inspection `depth` default is now back at 2. #24326 * dgram,net: * Added ipv6Only option for `net` and `dgram`. #23798 * http: * Chosing between the http parser is now possible per runtime flag. #24739 * readline: * The `readline` module now supports async iterators. #23916 * repl: * The multiline history feature is removed. #24804 * tls: * Added min/max protocol version options. #24405 * The X.509 public key info now includes the RSA bit size and the elliptic curve. #24358 * url: * `pathToFileURL()` now supports LF, CR and TAB. #23720 * Windows: * Tools are not installed using Boxstarter anymore. #24677 * The install-tools scripts or now included in the dist. #24233 * Added new collaborator: * [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655 PR-URL: #24854

This reverts commit eb42c1e. PR-URL: nodejs#24804 Refs: nodejs#24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This reverts commit dd7a3d2. PR-URL: nodejs#24804 Refs: nodejs#24231 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Notable Changes: * console,util: * `console` functions now handle symbols as defined in the spec. nodejs#23708 * The inspection `depth` default is now back at 2. nodejs#24326 * dgram,net: * Added ipv6Only option for `net` and `dgram`. nodejs#23798 * http: * Chosing between the http parser is now possible per runtime flag. nodejs#24739 * readline: * The `readline` module now supports async iterators. nodejs#23916 * repl: * The multiline history feature is removed. nodejs#24804 * tls: * Added min/max protocol version options. nodejs#24405 * The X.509 public key info now includes the RSA bit size and the elliptic curve. nodejs#24358 * url: * `pathToFileURL()` now supports LF, CR and TAB. nodejs#23720 * Windows: * Tools are not installed using Boxstarter anymore. nodejs#24677 * The install-tools scripts or now included in the dist. nodejs#24233 * Added new collaborator: * [antsmartian](https://github.com/antsmartian) - Anto Aravinth. nodejs#24655 PR-URL: nodejs#24854

BridgeAR requested a review from antsmartian December 3, 2018 13:47

nodejs-github-bot added readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem. labels Dec 3, 2018

BridgeAR changed the title ~~Revert multiline history~~ repl: revert multiline history Dec 3, 2018

antsmartian approved these changes Dec 3, 2018

View reviewed changes

BridgeAR requested a review from targos December 3, 2018 17:09

targos approved these changes Dec 3, 2018

View reviewed changes

Fishrock123 approved these changes Dec 3, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 3, 2018

targos mentioned this pull request Dec 4, 2018

repl history broke since 11.2.0 #24821

Closed

BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 4, 2018

joyeecheung mentioned this pull request Dec 5, 2018

CI failures: 20181201-20181205 nodejs/reliability#19

Closed

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2018

BridgeAR added 2 commits December 5, 2018 18:24

Revert "repl: handle buffered string logic on finish"

ced4324

This reverts commit eb42c1e.

Revert "lib: repl multiline history support"

1a33e14

This reverts commit dd7a3d2.

BridgeAR force-pushed the fix-multiline-history branch from 746b235 to 1a33e14 Compare December 5, 2018 17:25

Trott closed this Dec 6, 2018

BridgeAR mentioned this pull request Dec 6, 2018

v11.4.0 proposal #24854

Merged

4 tasks

aleclarson mentioned this pull request Jan 21, 2019

feat: command history TypeStrong/ts-node#757

Closed

BethGriggs added dont-land-on-v10.x and removed dont-land-on-v10.x labels Jul 3, 2019

BridgeAR deleted the fix-multiline-history branch January 20, 2020 11:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

repl: revert multiline history#24804

repl: revert multiline history#24804
BridgeAR wants to merge 2 commits intonodejs:masterfrom
BridgeAR:fix-multiline-history

BridgeAR commented Dec 3, 2018

Uh oh!

nodejs-github-bot commented Dec 3, 2018

Uh oh!

antsmartian commented Dec 3, 2018

Uh oh!

antsmartian commented Dec 3, 2018

Uh oh!

addaleax commented Dec 3, 2018

Uh oh!

BridgeAR commented Dec 4, 2018

Uh oh!

addaleax commented Dec 4, 2018

Uh oh!

BridgeAR commented Dec 4, 2018

Uh oh!

addaleax commented Dec 4, 2018

Uh oh!

addaleax commented Dec 5, 2018

Uh oh!

BridgeAR commented Dec 5, 2018

Uh oh!

danbev commented Dec 6, 2018 •

edited

Loading

Uh oh!

Trott commented Dec 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

BridgeAR commented Dec 3, 2018

Checklist

Uh oh!

nodejs-github-bot commented Dec 3, 2018

Uh oh!

antsmartian commented Dec 3, 2018

Uh oh!

antsmartian commented Dec 3, 2018

Uh oh!

addaleax commented Dec 3, 2018

Uh oh!

BridgeAR commented Dec 4, 2018

Uh oh!

addaleax commented Dec 4, 2018

Uh oh!

BridgeAR commented Dec 4, 2018

Uh oh!

addaleax commented Dec 4, 2018

Uh oh!

addaleax commented Dec 5, 2018

Uh oh!

BridgeAR commented Dec 5, 2018

Uh oh!

danbev commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Dec 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

danbev commented Dec 6, 2018 •

edited

Loading