doc: add authority and scheme psuedo headers#24777
Closed
kenigbolo wants to merge 3 commits intonodejs:masterfrom
Closed
doc: add authority and scheme psuedo headers#24777kenigbolo wants to merge 3 commits intonodejs:masterfrom
kenigbolo wants to merge 3 commits intonodejs:masterfrom
Conversation
This pull request adds the request psuedo headers authority and scheme to the http2 documentation Fixes: nodejs#23825
nodejs-github-bot
added
doc
Trott
reviewed
Dec 2, 2018
Trott
reviewed
Dec 2, 2018
Member
|
@nodejs/http2 |
vsemozhetbyt
reviewed
Dec 2, 2018
Contributor
vsemozhetbyt
left a comment
vsemozhetbyt
left a comment
There was a problem hiding this comment.
Thank you. Just some nits.
Contributor
Author
|
@vsemozhetbyt Thanks. Made the adjustments accordingly |
addaleax
approved these changes
Dec 4, 2018
Contributor
danbev
approved these changes
Dec 5, 2018
vsemozhetbyt
added
the
author ready
Contributor
|
Landed in bb01597 |
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: nodejs#24777 Fixes: nodejs#23825 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc: add authority and scheme psuedo headers to http2.md
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation
Fixes: #23825
Checklist