lib: remove duplicated noop function#24770
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:bootstrap
Closed
lib: remove duplicated noop function#24770ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:bootstrap
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:bootstrap
Conversation
addaleax
approved these changes
Dec 1, 2018
cjihrig
approved these changes
Dec 1, 2018
Member
lpinca
approved these changes
Dec 1, 2018
BridgeAR
approved these changes
Dec 1, 2018
BridgeAR
added
the
author ready
starkwang
approved these changes
Dec 3, 2018
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19171/ |
Member
|
Needs a rebase. |
Trott
removed
the
author ready
Member
Author
|
@Trott Done, needs CI again ? |
Contributor
Member
addaleax
added
lib / src
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2018
PR-URL: nodejs#24770 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Weijia Wang <starkwang@126.com>
Member
|
Landed in a89b873` |
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
PR-URL: #24770 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Weijia Wang <starkwang@126.com>
This was referenced Dec 7, 2018
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Jan 11, 2019
PR-URL: nodejs#24770 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Weijia Wang <starkwang@126.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24770 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Weijia Wang <starkwang@126.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
PR-URL: nodejs#24770 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Weijia Wang <starkwang@126.com> Backport-PR-URL: nodejs#25446
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a
noopfunction outside theifstatement in the line 609 :)node/lib/internal/bootstrap/node.js
Line 609 in eb6741b
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes