http: destroy the socket on parse error

[lpinca]

Destroy the socket if the 'clientError' event is emitted and there is
no listener for it.

Fixes: #24586

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1750/pipeline

[lpinca]

cc: @dougwilson

[addaleax]

Would it make sense to wait for the write() callback to be called?

[lpinca]

@addaleax @mcollina the assumption is that badRequestResponse is the first chunk that is written to the socket (it initiates the HTTP response). As such it is written synchronously so I think there is no need to wait for the write callback.

[mcollina]

We should give a chance to the event loop to write this. How about we put it into a setImmediate?

[addaleax]

Using setImmediate() would make things even more race-y. I think it’s either using the write callback or not delaying it at all (which is still race-y, but probably more consistent?).

[mcollina]

LGTM

[lpinca]

CI: https://ci.nodejs.org/job/node-test-pull-request/19118/ ✔️

[mcollina]

Can you please verify that http://npm.im/on-finished tests pass with this patch?

[lpinca]

Will do later today.

[lpinca]

Btw we also need #24738 as we had a regression in v11.2.0 and there are cases where 'clientError' is not emitted.

[lpinca]

[luigi@fedora on-finished]$ ../dev/node/node node_modules/.bin/mocha


  onFinished(res, listener)
    ✓ should invoke listener given an unknown object
    when the response finishes
      ✓ should fire the callback
      ✓ should include the response object
      ✓ should fire when called after finish
    when using keep-alive
      ✓ should fire for each response (45ms)
    when requests pipelined
      ✓ should fire for each request
    when response errors
      ✓ should fire with error
      ✓ should include the response object
    when the response aborts
      ✓ should execute the callback
    when calling many times on same response
      ✓ should not print warnings

  isFinished(res)
    ✓ should return undefined for unknown object
    ✓ should be false before response finishes
    ✓ should be true after response finishes
    when requests pipelined
      ✓ should have correct state when socket shared
      ✓ should handle aborted requests
    when response errors
      ✓ should return true
    when the response aborts
      ✓ should return true

  onFinished(req, listener)
    when the request finishes
      ✓ should fire the callback
      ✓ should include the request object
      ✓ should fire when called after finish
    when using keep-alive
      ✓ should fire for each request (43ms)
    when request errors
      ✓ should fire with error
      ✓ should include the request objecy
    when the request aborts
      ✓ should execute the callback
    when calling many times on same request
      ✓ should not print warnings
    when CONNECT method
      ✓ should fire when request finishes
      ✓ should fire when called after finish
    when Upgrade request
      ✓ should fire when request finishes
      ✓ should fire when called after finish

  isFinished(req)
    ✓ should return undefined for unknown object
    ✓ should be false before request finishes
    ✓ should be true after request finishes
    when request data buffered
      ✓ should be false before request finishes
    when request errors
      ✓ should return true
    when the request aborts
      ✓ should return true
    when CONNECT method
      ✓ should be true immediately
      ✓ should be true after request finishes
    when Upgrade request
      ✓ should be true immediately
      ✓ should be true after request finishes


  39 passing (200ms)

[Trott]

Landed in ff7d053

[Fishrock123]

Ah, nice fix.

[MylesBorins]

This lands cleanly on 10.x. How time sensitive is it to get this out in LTS?

[lpinca]

@MylesBorins I would say as soon as possible.

[mcollina]

We talked about it at today's @nodejs/tsc meeting and we think this fix should be released asap.

[MylesBorins]

/cc @codebytere please pick up this commit in the 10.x release

…

On Wed, Dec 5, 2018, 7:28 AM Matteo Collina ***@***.*** wrote: We talked about it at today's @nodejs/tsc <https://github.com/orgs/nodejs/teams/tsc> meeting and we think this fix should be released asap. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24757 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV3-rtn_4KT6_G_PWC3cWXeC0ztPvks5u17vRgaJpZM4Y8LBu> .