tls: use for loop instead of forEach

[ZYSzys]

Using native for loop instead of forEach may make the performance a bit of better ?

On the other hand, it's for consistency with proxiedMethods

Refs: #11582

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[apapirovski]

This code runs once at the point where this module is required. It'll be a completely imperceptible performance difference. Unrolling this loop altogether would make the performance optimal but doesn't mean we should do that. We should always consider magnitude of any performance improvements.

[ZYSzys]

This change wouldn't cause any bad effect, even may make a bit of better, so why not do so ?

[Trott]

This makes the code less readable/maintainable for a micro-optimization that is unlikely to have any impact.

[ZYSzys]

🤔Wondering what do you think about the proxiedMethods, these two parts are almost same with each other:
Proxy HandleWrap, PipeWrap and TCPWrap methods

Proxy TLSSocket handle methods:

[silverwind]

I'd say make all non-critical loops for...of. But such refactors should be done at per-file level at minimum, certainly not on a per-loop level.

[apapirovski]

Wondering what do you think about the proxiedMethods, these two parts are almost same with each other

I just don't see any reason to churn on either of these. Both are valid JavaScript that works and changing them will bring no benefit beyond adding another layer to the blame output that someone will have to puzzle through when trying to actually work on that code.

[devsnek]

in recent versions of v8, forEach is faster than a loop in cases like this. plus the loop is more readable.

[silverwind]

in recent versions of v8, forEach is faster

I think for pratical reasons, all for variants perform the same (https://jsperf.com/for-vs-foreach/293). I came to prefer for...of recentely because (unlike forEach) it allows the use of control statements like return, break and continue.

[ZYSzys]

Thanks all of you to explain for this, let me understand a lot.

If no one would like to talk more about this, please feel free to close it.

[cjihrig]

I'll close this out, but thanks for the PR.