Closed
Conversation
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc.
richardlau
approved these changes
Nov 21, 2018
vsemozhetbyt
approved these changes
Nov 21, 2018
vsemozhetbyt
added
the
author ready
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Member
Author
|
Landed in 7cc3b1e |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 21, 2018
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: nodejs#24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: #24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: #24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: #24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: nodejs#24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: #24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: #24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the
author readytext in the COLLABORATOR_GUIDE forscannability, readability, etc.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes