src: use arraysize instead of hardcode number#24473
Closed
leeight wants to merge 2 commits intonodejs:masterfrom
Closed
src: use arraysize instead of hardcode number#24473leeight wants to merge 2 commits intonodejs:masterfrom
leeight wants to merge 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
leeight
force-pushed
the
use-arrarysize
branch
3 times, most recently
from
a52e8d4 to
2c35649
Compare
jasnell
approved these changes
Nov 19, 2018
addaleax
approved these changes
Nov 19, 2018
sagirk
approved these changes
Nov 19, 2018
leeight
force-pushed
the
use-arrarysize
branch
from
2c35649 to
cb4a1b1
Compare
lpinca
reviewed
Nov 20, 2018
leeight
force-pushed
the
use-arrarysize
branch
from
cb4a1b1 to
c05fa48
Compare
Member
addaleax
added
the
author ready
leeight
force-pushed
the
use-arrarysize
branch
from
c05fa48 to
f059332
Compare
leeight
force-pushed
the
use-arrarysize
branch
from
f059332 to
22fc963
Compare
Member
|
Looks like the most recent changes broke Travis? |
addaleax
removed
the
author ready
refack
reviewed
Nov 24, 2018
leeight
force-pushed
the
use-arrarysize
branch
from
22fc963 to
49ada82
Compare
Contributor
refack
approved these changes
Nov 24, 2018
refack
added
the
author ready
addaleax
requested changes
Nov 24, 2018
addaleax
removed
the
author ready
Co-Authored-By: leeight <leeight@gmail.com>
Contributor
Contributor
|
P.S. I'm self-assigned this so I'll get notifications from GitHub, and so that I will not lose track of it and help steward it to completion. |
addaleax
approved these changes
Dec 1, 2018
Member
|
Landed in adbf947, thanks for the PR! 🎉 By the way, if your PR doesn’t receive much attention within a day or two, and you think it’s ready to go, feel free to bump the thread by commenting (e.g. “bump” or pinging involved individuals like me). 🙂 |
addaleax
pushed a commit
that referenced
this pull request
Dec 1, 2018
PR-URL: #24473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
PR-URL: #24473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes