crypto: remove unnecessary fully qualified names#24452
Merged
refack merged 1 commit intonodejs:masterfrom Nov 17, 2018
codegagan:node-crypto
Merged
crypto: remove unnecessary fully qualified names#24452refack merged 1 commit intonodejs:masterfrom codegagan:node-crypto
refack merged 1 commit intonodejs:masterfrom
codegagan:node-crypto
Conversation
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Nov 17, 2018
addaleax
approved these changes
Nov 17, 2018
addaleax
added
author ready
cjihrig
approved these changes
Nov 17, 2018
refack
approved these changes
Nov 17, 2018
Contributor
|
ci.nodejs.org/job/node-test-pull-request/18700 (flake #22339) Please 👍 to fast-track |
Contributor
|
Hello @codegagan and welcome. Thank you for your contribution 🥇 P.S. If you have any questions you can also feel free to contact me directly. |
PR-URL: #24452 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
refack
removed
the
author ready
Contributor
|
Congratulations @codegagan on getting promoted by GitHub form: Hope to see you contributing more in the future. |
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
PR-URL: #24452 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Contributor
Author
|
Thankyou @refack for motivation and support. |
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24452 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24452 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The namespaces were already elevated but the code still had fully qualified names.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes