doc: update 11.0.0 changelog with missing commit#24404
Closed
Trott wants to merge 3 commits intonodejs:masterfrom
Closed
doc: update 11.0.0 changelog with missing commit#24404Trott wants to merge 3 commits intonodejs:masterfrom
Trott wants to merge 3 commits intonodejs:masterfrom
Conversation
Member
Author
|
So, this is a little strange in that the commit is manually inserted into the 11.0.0 semver-major list even though it was introduced (by accidentally overlooking the semver-ness) in 10.x, where it was subsequently reverted. But we still want to note it in 11.0.0. So, although there may be a better way to do it, I've inserted it into the normal flow. That has to be better than omitting it at least, right? |
refack
approved these changes
Nov 16, 2018
Member
Author
Contributor
The remaining issue is that it's not in the blog post, |
Member
Author
|
danbev
approved these changes
Nov 20, 2018
Contributor
|
Landed in b32c5f0. |
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24404 Fixes: nodejs#23846 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #23846
Please 👍 here to fast-track.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes