test: remove unused function arguments in async-hooks tests#24368
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove unused function arguments in async-hooks tests#24368Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Remove unused function arguments in two async-hooks tests.
nodejs-github-bot
added
async_hooks
Member
Author
addaleax
approved these changes
Nov 14, 2018
lpinca
approved these changes
Nov 14, 2018
Member
Author
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18618/ |
Member
Author
|
Took problematic host offline. Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18620/ |
Member
Author
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18668/ |
fhinkel
approved these changes
Nov 16, 2018
Member
Author
|
Landed in b7e9804 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 16, 2018
Remove unused function arguments in two async-hooks tests. PR-URL: nodejs#24368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
Remove unused function arguments in two async-hooks tests. PR-URL: #24368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Remove unused function arguments in two async-hooks tests. PR-URL: #24368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
Remove unused function arguments in two async-hooks tests. PR-URL: #24368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Remove unused function arguments in two async-hooks tests. PR-URL: #24368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused function arguments in two async-hooks tests.
(This actually started as a bigger change but then I realized the bigger change was wrong. Oops.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes