build,tools: update make-v8.sh for ppc64le#24293
Merged
refack merged 1 commit intonodejs:masterfrom Nov 16, 2018
Merged
Conversation
nodejs-github-bot
added
tools
Contributor
Author
|
V8 CI (with temporary config to use this file): |
bnoordhuis
approved these changes
Nov 12, 2018
| ln -s /usr/bin/$CC "$BUILD_TOOLS/gcc" | ||
| g++ --version | ||
| export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config-files | ||
| gn gen out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="ppc64" target_cpu="ppc64"' |
Member
There was a problem hiding this comment.
It took me a while to figure out how V8 knows the endianness, since it's not specified on the command line.
I thought it checked compiler defines but no, it's defined in build/config/host_byteorder.gni and it basically assumes LE unless the host arch is one of a select few. ppc64 is not one of the select except when os=AIX.
(And yes, host arch, not target arch. It's not cross-compile ready.)
fhinkel
approved these changes
Nov 13, 2018
Contributor
Author
|
Lite-CI (since it's only used by test-v8 anyway): https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1615/ |
refack
force-pushed
the
update-tools-make-v8-part2
branch
from
c8550fa to
b5ecf2e
Compare
refack
force-pushed
the
update-tools-make-v8-part2
branch
from
b5ecf2e to
c8550fa
Compare
PR-URL: nodejs#24293 Fixes: nodejs/build#1536 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
refack
force-pushed
the
update-tools-make-v8-part2
branch
from
c8550fa to
3d4b281
Compare
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
PR-URL: #24293 Fixes: nodejs/build#1536 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24293 Fixes: nodejs/build#1536 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
PR-URL: #24293 Fixes: nodejs/build#1536 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24293 Fixes: nodejs/build#1536 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #23839
Fixes: nodejs/build#1536
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes