Conversation
nodejs-github-bot
added
build
richardlau
approved these changes
Nov 8, 2018
cjihrig
approved these changes
Nov 8, 2018
ZYSzys
approved these changes
Nov 8, 2018
vsemozhetbyt
approved these changes
Nov 8, 2018
vsemozhetbyt
added
the
author ready
Member
Author
|
Post fix-up lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1541/ |
refack
removed
the
author ready
Minor edits to BUILDING.md to keep sentences short and clear.
Member
Author
refack
approved these changes
Nov 9, 2018
Trott
added
the
author ready
Member
Author
|
Landed in c17fef7. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 10, 2018
Minor edits to BUILDING.md to keep sentences short and clear. PR-URL: nodejs#24243 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
Minor edits to BUILDING.md to keep sentences short and clear. PR-URL: #24243 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Minor edits to BUILDING.md to keep sentences short and clear. PR-URL: nodejs#24243 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Nov 15, 2018
This was referenced Nov 16, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 14, 2018
Minor edits to BUILDING.md to keep sentences short and clear. PR-URL: #24243 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
Minor edits to BUILDING.md to keep sentences short and clear. PR-URL: #24243 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor edits to BUILDING.md to keep sentences short and clear.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes