lib: move encodeStr function to internal for reusable#24242
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:encodeStr
Closed
lib: move encodeStr function to internal for reusable#24242ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:encodeStr
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:encodeStr
Conversation
Contributor
Member
Author
|
Is the Benchmark CI result acceptable ? 🤔 BTW, didn't understand why we use function
instead of
|
Contributor
The reason is that we allow users to override the |
Contributor
I suppose so. |
jasnell
approved these changes
Nov 10, 2018
Member
|
@nodejs/url This doesn't technically need another review, but it would be nice. |
Member
Member
|
Landed in db9a745 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 21, 2018
PR-URL: nodejs#24242 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24242 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encodeStr function and qsEscape function are almost the same.
Extract encodeStr function and move it to internal for reusable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @mscdex