console: cover .assert with single argument#24188
Closed
mroderick wants to merge 1 commit intonodejs:masterfrom
mroderick:console-assert-coverage-single-argument
Closed
console: cover .assert with single argument#24188mroderick wants to merge 1 commit intonodejs:masterfrom mroderick:console-assert-coverage-single-argument
mroderick wants to merge 1 commit intonodejs:masterfrom
mroderick:console-assert-coverage-single-argument
Conversation
addaleax
added
the
code-and-learn
addaleax
approved these changes
Nov 6, 2018
BridgeAR
approved these changes
Nov 6, 2018
addaleax
added
the
author ready
Member
jasnell
approved these changes
Nov 10, 2018
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18537/ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 11, 2018
PR-URL: nodejs#24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in e3d05a6. |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 14, 2018
PR-URL: #24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
PR-URL: #24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers
console.assertwith a single argument.See https://coverage.nodejs.org/coverage-d32b5bd567544f5b/root/console.js.html#L295
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes