test: add typeerror for vm/compileFunction params#24179
Closed
dYale wants to merge 2 commits intonodejs:masterfrom
Closed
test: add typeerror for vm/compileFunction params#24179dYale wants to merge 2 commits intonodejs:masterfrom
dYale wants to merge 2 commits intonodejs:masterfrom
Conversation
ba92b1e to
a401f13
Compare
addaleax
approved these changes
Nov 6, 2018
joyeecheung
approved these changes
Nov 6, 2018
BridgeAR
approved these changes
Nov 6, 2018
jasnell
approved these changes
Nov 10, 2018
Member
Member
|
linter error: the summary of the linter error message is that you need to de-indent all changes by 2 spaces, and move the |
Member
|
forgot to ping @dYale |
Member
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18637/ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24179 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 3212f77. |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 15, 2018
PR-URL: #24179 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
PR-URL: #24179 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes