test: net eaddrinuse, change arguments order in strictEqual#24156
Closed
Paul-Isache wants to merge 1 commit intonodejs:masterfrom
Closed
test: net eaddrinuse, change arguments order in strictEqual#24156Paul-Isache wants to merge 1 commit intonodejs:masterfrom
Paul-Isache wants to merge 1 commit intonodejs:masterfrom
Conversation
BridgeAR
approved these changes
Nov 6, 2018
cjihrig
approved these changes
Nov 6, 2018
gireeshpunathil
approved these changes
Nov 6, 2018
addaleax
added
the
code-and-learn
trivikr
approved these changes
Nov 7, 2018
Member
|
Hi @Paul-Isache, the author of this commit is not registered on Github (steps defined here) Either:
|
Paul-Isache
force-pushed
the
test-net-eaddrinuse
branch
from
97aeb47 to
e32c2ca
Compare
Contributor
Author
|
Hi @trivikr, |
Member
|
Thanks @Paul-Isache, confirmed that it looks good! |
trivikr
approved these changes
Nov 7, 2018
Member
Member
|
failures in arm and smart-os platforms seen yesterday, looks like some infra issues that got fixed. resume CI: https://ci.nodejs.org/job/node-test-pull-request/18484/ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 10, 2018
Fix actual/expected ordering in test-net-eaddrinuse. PR-URL: nodejs#24156 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
Landed in a67e0a6. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
Fix actual/expected ordering in test-net-eaddrinuse. PR-URL: #24156 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Fix actual/expected ordering in test-net-eaddrinuse. PR-URL: nodejs#24156 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 13, 2018
Fix actual/expected ordering in test-net-eaddrinuse. PR-URL: #24156 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
Fix actual/expected ordering in test-net-eaddrinuse. PR-URL: #24156 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes