test: fix order of arguments in assert.strictEqual#24145
Closed
eiskalteschatten wants to merge 1 commit intonodejs:masterfrom
eiskalteschatten:master
Closed
test: fix order of arguments in assert.strictEqual#24145eiskalteschatten wants to merge 1 commit intonodejs:masterfrom eiskalteschatten:master
eiskalteschatten wants to merge 1 commit intonodejs:masterfrom
eiskalteschatten:master
Conversation
cjihrig
approved these changes
Nov 6, 2018
| assert.strictEqual(-1, bufferString.lastIndexOf('a man a plan a canal mexico')); | ||
| assert.strictEqual(-1, bufferString | ||
| .lastIndexOf('a man a plan a canal mexico city')); | ||
| assert.strictEqual(-1, bufferString.lastIndexOf(Buffer.from('a'.repeat(1000)))); |
Member
There was a problem hiding this comment.
just wondering why some of these were left behind? I guess those can also follow the same change?
Contributor
Author
There was a problem hiding this comment.
That was task given to me by @BridgeAR which specified the exact line numbers to change. Maybe he can expand upon why he chose them?
Member
There was a problem hiding this comment.
I was just checking whether there is any reason that is unknown to me. no worries, thanks for clarifying.
addaleax
added
the
code-and-learn
BridgeAR
approved these changes
Nov 6, 2018
Member
|
JS lint failure: /cc @nodejs/build |
gireeshpunathil
approved these changes
Nov 8, 2018
Member
Member
Trott
added
the
author ready
Member
|
landed as ef907bb thank you @eiskalteschatten for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 10, 2018
PR-URL: #24145 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
Author
|
You're very welcome. I will have a look at the link you posted because I would be interested in contributing more. |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24145 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24145 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 14, 2018
PR-URL: #24145 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
PR-URL: #24145 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the order of the arguments for several instances of assert.strictEqual in test/parallel/test-buffer-indexof.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes