test: fixes order of arguments in assert.strictEqual#24140
Closed
posth wants to merge 1 commit intonodejs:masterfrom
Closed
test: fixes order of arguments in assert.strictEqual#24140posth wants to merge 1 commit intonodejs:masterfrom
posth wants to merge 1 commit intonodejs:masterfrom
Conversation
File: test/parallel/test-http-client-upload-buf.js
cjihrig
approved these changes
Nov 6, 2018
gireeshpunathil
approved these changes
Nov 6, 2018
Member
|
let me know if these are coming out of NodeConfEU code & learn, so that it can be labelled appropriately, thanks! |
addaleax
approved these changes
Nov 6, 2018
addaleax
added
the
code-and-learn
BridgeAR
approved these changes
Nov 6, 2018
trivikr
approved these changes
Nov 7, 2018
Member
Member
|
pls thumbs up for fast tracking |
Member
|
one test failed in |
Member
|
re-run to be absolutely sure. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 9, 2018
File: test/parallel/test-http-client-upload-buf.js PR-URL: nodejs#24140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
landed as 16a199a thank you @posth for the contribution. Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps/ |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
File: test/parallel/test-http-client-upload-buf.js PR-URL: #24140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
File: test/parallel/test-http-client-upload-buf.js PR-URL: nodejs#24140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 13, 2018
File: test/parallel/test-http-client-upload-buf.js PR-URL: #24140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
File: test/parallel/test-http-client-upload-buf.js PR-URL: #24140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the order of the arguments of the
assert.strictEqual()oftest/parallel/test-http-client-upload-buf.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes